Re: [Discuss] Geospatial Support

2024-05-29 Thread Jia Yu
Hi Dmtro, Thanks for your email. To add to Szehon's answer, 1. How to represent Snowflake Geometry and Geography type in Iceberg, given the Geo Iceberg Phase 1 design: Answer: Mapping 1 (possible): Snowflake Geometry + SRID: 4326 -> Iceberg Geometry + CRS84 + edges: Planar Mapping 2 (impossible)

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Yufei Gu
Glad we have reached a certain consensus here. Agreed with Dan, we need to follow the deprecating process to remove the token endpoint, which mitigates compatibility issues. For client-side change, other than deprecating the current default token endpoint and making the oauth2-server-uri mandato

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Steven Wu
> I do think we need a more complete discussion around client reference implementation and I would be opposed to making any changes to the spec until that is resolved. Agree with Dan's comment on discussion and proposal on client side story. Client side needs to combine both the regular REST and

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Daniel Weeks
I feel there's general openness to removing the specific OAuth2 portions of the REST Spec as they're largely duplicative of what's covered in the OAuth2 RFC. However, I do think we need a more complete discussion around client reference implementation and I would be opposed to making any changes t

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Robert Stupp
Jack's proposal is pretty much along what we've been thinking of. We can help with OAuth 2 client implementations for Java that support bearer, client-credentials, password as well as authorization code and device code flows (see docs [1] and implementation [2]. All implementations are built v

Re: [Discuss] Geospatial Support

2024-05-29 Thread Szehon Ho
Hi Dmytro Thank you for looking through the proposal and excited to hear from you guys! I am not a 'geo expert' and I will definitely need to pull in Jia Yu for some of these points. Although most calculations are done on the query engine, Iceberg reference implementations (ie, Java, Python) doe

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Jack Ye
Just to reiterate my points discussed in the community sync here: the more I think about it the more I agree the OAuth endpoint *should be removed from the REST spec*. Even though the endpoint is optional, and even if we do not care about the security concerns, it still provides users an impression

Re: Addressing security questions in the Iceberg REST specification

2024-05-29 Thread Steven Wu
Wondering if the auth endpoints can be separated out to a separate OpenAPI spec file. Then we still have some reference for interactions with auth server and make it clear it is not required as part of the REST catalog server. In most enterprise environments, auth server is likely a separate server

RE: [Discuss] Geospatial Support

2024-05-29 Thread Dmytro Koval
Dear Szehon and Iceberg Community, This is Dmytro, Peter, Aihua, and Tyler from Snowflake. As part of our desire to be more active in the Iceberg community, we’ve been looking over this geospatial proposal. We’re excited geospatial is getting traction, as we see a lot of geo usage within Snowflak