Re: PR: implementation of timestamp_ns and timestamptz_ns

2023-11-08 Thread Jacob Marble
Here is the second, smaller PR, touching only the API module. https://github.com/apache/iceberg/pull/9008 Running tests locally triggers a few failures in modules Spark and Flink, but I'm not sure what to do about those yet. On Wed, Nov 8, 2023 at 10:41 AM Jacob Marble wrote: > Per Ryan's sugg

Re: PR: implementation of timestamp_ns and timestamptz_ns

2023-11-08 Thread Jacob Marble
Per Ryan's suggestion, I'm breaking this up into smaller PRs. The first should be very non-controversial - the spec needs an update so that ORC types can be converted back to Iceberg types. https://github.com/apache/iceberg/pull/9007 On Tue, Nov 7, 2023 at 11:41 AM Jean-Baptiste Onofré wrote: >

Re: Updating the Iceberg table architecture diagram

2023-11-08 Thread Ryan Blue
I'm not sure that an update to the diagram is needed. Adding stats files and delete files makes the diagram harder to follow. And its purpose is to clearly show the high-level structure of the format to help people understand the basic idea, not to show all of the details. I think more complexity u

Re: Updating the Iceberg table architecture diagram

2023-11-08 Thread Jason Hughes
since v2 has been out for a while and most tools that support iceberg support v2 (not to mention some only support v2), I think having a single diagram and using dotted lines for the delete manifests and delete files will cause more confusion than benefit. also because of the support and adoption o