Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-20 Thread Daniel Weeks
Fokko, I think I found a similar filter problems while experimenting: Using a filter like: t.scan().filter("location_id in (1,2,3)").to_arrow() appears to filter correctly. However, a "like" query silently filters everything out: t.scan().filter("location_id in (1,2,3) and zone_name like 'Jam%'")

Re: Nested column types and equality delete files

2023-10-20 Thread Ryan Blue
You're right. It calls out that `float` and `double` columns can't be used, but there's a question around what is "equal" for maps, at the least. I think the reasonable thing to do is to allow top-level fields and fields that are nested within only struts. Any field nested within a map or list sho

Nested column types and equality delete files

2023-10-20 Thread Micah Kornfield
Hi Iceberg Dev, Are equality delete files intended to support nested columns of nested types (lists, structs and maps) or "children" of nested types? I couldn't find anything prohibiting it in the specification [1] (apologies if I missed it) but it seems like this adds a fair amount of complexi

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-20 Thread Ryan Blue
Fokko clarified offline that the commit I was looking for wasn't moved over to the iceberg-python repo because it didn't affect files in the python/ directory. The last commit that did was https://github.com/apache/iceberg/commit/187c9441a1830d323c862136e74f83876ab400c8, which is in the 0.5.x branc

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-20 Thread Ryan Blue
The release build looks fine: - Ran RAT checks - Validated signature and checksum - Ran tests in Python 3.10.5 Unfortunately, I haven't been able to verify the set of changes. I was looking at the 0.5.0-rc3 tag in the main repo: https://github.com/apache/iceberg/commit/f798b06246e67131d413dfceece5

Re: JDBC namespace existence check #8340

2023-10-20 Thread Ryan Blue
Thanks! Looks like it's about ready but needs some additional fixes to the tests. On Thu, Oct 19, 2023 at 4:43 PM Steve Zhang wrote: > Hey Iceberg Community: > >I want to ask for some help review on this PR > https://github.com/apache/iceberg/pull/8340. It tried to solve the > current issue