回复: Discussion about applying spotless for scala code

Yeah, it will influence many files. The good news is there are not too many Scala files compared with Java files. There are indeed some problems to rebase code from fork or PRs. What we have done for Java code is: First, rebasing to the commit which adds the spotless config, second applying the

Re: Discussion about applying spotless for scala code

Is this the right time to do so? It will bring a lot of conflicts with open PRs and forked codebases. It also hides other commits when I do `Git Blame`. My two cents, Manu On Wed, Jul 19, 2023 at 12:24 AM Liu Xianyang wrote: > Hello everyone: > I'd like the raise a discussion about applying s

Re: [VOTE] Release Apache Iceberg 1.3.1 RC1

Hi Szehon, +1 (binding) - Checked the signature and hash - Ran the RAT checks - Did a local build and ran the tests (all passed, except TestS3RestSigner tests, since #7742 is not backported). - Ran against Trino master

Discussion about applying spotless for scala code

Hello everyone: I'd like the raise a discussion about applying spotless for Scala code. We need to get more advice since it will change a lot of files. We have already applied spotless for Java code which helps developers easily follow the code style. And also it makes better code management.