Re: [VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Jack Ye
+1 (binding) Verified checksum, signature, license, test, test-s3. Ran basic checks for Glue catalog, also verified the row filter issue is fixed: [image: Screenshot 2023-06-27 at 10.55.47 PM.png] Best, Jack Ye On Tue, Jun 27, 2023 at 10:25 PM Jean-Baptiste Onofré wrote: > +1 (non binding) >

Re: [VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Jean-Baptiste Onofré
+1 (non binding) I did quick tests and it looks good. Thanks! Regards JB On Tue, Jun 27, 2023 at 10:37 PM Fokko Driesprong wrote: > > All, > > > Excited to start the 0.4.0 PyIceberg release process. The 0.4.0 release is > packed with awesome features: > > Support for converting Parquet schemas

Re: [VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Ryan Blue
+1 Ran RAT, make test, validated checksums. Looks like I had an old version of pyparsing locally. On Tue, Jun 27, 2023 at 2:32 PM Driesprong, Fokko wrote: > Sorry about that. Looks like I didn't properly clean up my dist/ folder. > I've updated the SVN location. I'll update the how-to-release g

Re: [VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Driesprong, Fokko
Sorry about that. Looks like I didn't properly clean up my dist/ folder. I've updated the SVN location. I'll update the how-to-release guide to make sure that this won't happen again. Kind regards, Fokko Op di 27 jun 2023 om 23:04 schreef Ryan Blue : > Any idea why there are rc1 artifacts here?

Re: [VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Ryan Blue
Any idea why there are rc1 artifacts here? https://dist.apache.org/repos/dist/dev/iceberg/pyiceberg-0.4.0rc2/ On Tue, Jun 27, 2023 at 1:37 PM Fokko Driesprong wrote: > All, > > > Excited to start the 0.4.0 PyIceberg release process. The 0.4.0 release > is packed with awesome features: > >- S

[VOTE] Release PyIceberg 0.4.0 RC2

2023-06-27 Thread Fokko Driesprong
All, Excited to start the 0.4.0 PyIceberg release process. The 0.4.0 release is packed with awesome features: - Support for converting Parquet schemas into Iceberg ones - Support for reading data using FSSpec

Re: [VOTE] Release PyIceberg 0.4.0 RC1

2023-06-27 Thread Driesprong, Fokko
Thank you Dan, great catch! I've pinned the version of pyparsing. It looks like it switched to non-greedy matching. The first commit updates the tests, which exposes the issue, and the second commit locks pyparsing to <3.1.0. It looks like the pyparsin

Re: [VOTE] Release PyIceberg 0.4.0 RC1

2023-06-27 Thread Daniel Weeks
I ran into an issue with the row filtering: t.scan(row_filter="location_id > 1").to_pandas() File ~/workspace/apache/releases/pyiceberg/0.4.0-rc1/pyiceberg-0.4.0/pyiceberg/schema.py:183, in Schema.find_field(self, name_or_id, case_sensitive) 180 field_id = self._lazy_name_to_id_lower.get(