Re: [discuss] keep the commit history when adding a new engine version

2022-05-12 Thread Reo Lei
That is great ! +1 for this. liwei li 于2022年5月13日周五 11:12写道: > Correct a clerical errr: > > 3. Modify the v3.3 files to make it work for spark 3.3 correct. > > Liwei Li > -- > *From:* Steven Wu > *Sent:* Friday, May 13, 2022 11:06:26 AM > *To:* dev@iceberg.apache.org

Re: [discuss] keep the commit history when adding a new engine version

2022-05-12 Thread liwei li
Correct a clerical errr: 3. Modify the v3.3 files to make it work for spark 3.3 correct. Liwei Li From: Steven Wu Sent: Friday, May 13, 2022 11:06:26 AM To: dev@iceberg.apache.org Subject: Re: [discuss] keep the commit history when adding a new engine version T

Re: [discuss] keep the commit history when adding a new engine version

2022-05-12 Thread Steven Wu
This is a good point. +1 for the proposal. On Thu, May 12, 2022 at 7:46 PM liwei li wrote: > Hi, guys > When we want to add support for a new version of an engine, simply copying > files from an old version to a new directory will cause git commit history > to be lost, making it difficult to fin

[discuss] keep the commit history when adding a new engine version

2022-05-12 Thread liwei li
Hi, guys When we want to add support for a new version of an engine, simply copying files from an old version to a new directory will cause git commit history to be lost, making it difficult to find file change records, we can only go to look for changes in the old path, but we don't know it in

Re: store rfc/review documents in code base

2022-05-12 Thread Rajarshi Sarkar
Hi Albert, You can find the design docs for the ongoing projects here: https://github.com/apache/iceberg/projects +1, for a centralized place to maintain the design docs (old and current ones). Though, code base might not be the right place for the same. Regards, Rajarshi Sarkar On Thu, May 12

store rfc/review documents in code base

2022-05-12 Thread Albert
Hi all, It seems difficult to find the review documents in google document, it's scattered around everywhere in the PRs issues etc. I maintained some link collections myself for reference. there are issues on the project finding these documents as well. can those review documents be put int