Re: Review request

2022-03-02 Thread Ryan Blue
Looks great. Sorry that I missed this one to review! On Wed, Mar 2, 2022 at 1:31 AM OpenInx wrote: > Thanks Peter for the great work. Just added my comments. > > On Wed, Mar 2, 2022 at 4:20 PM Peter Vary > wrote: > >> Hi Team, >> >> I have a PR (https://github.com/apache/iceberg/pull/4218) wait

Re: [External] Re: Continuing the Secondary Index Discussion

2022-03-02 Thread zaicheng wang
Hi folks, This is Zaicheng from bytedance. We spend some time working on solving the index invalidation problem as we discussed in the dev email channel. And when we are working on the POC, we also realize there are some metadata changes that might be introduced. We put these details into a docume

Re: Review request

2022-03-02 Thread OpenInx
Thanks Peter for the great work. Just added my comments. On Wed, Mar 2, 2022 at 4:20 PM Peter Vary wrote: > Hi Team, > > I have a PR (https://github.com/apache/iceberg/pull/4218) waiting for > review where with basically a 1 liner change we can improve the performance > of the GenericReader clas

Review request

2022-03-02 Thread Peter Vary
Hi Team, I have a PR (https://github.com/apache/iceberg/pull/4218 ) waiting for review where with basically a 1 liner change we can improve the performance of the GenericReader classes by 10–20%. This onliner is needed in 3 places. The other part of