[GitHub] [iceberg-docs] rdblue commented on pull request #2: Landing-Page Site and Versioned Docs Site

2021-12-21 Thread GitBox
rdblue commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-999187098 @samredai, if I understand the workflow correctly, it sounds like you're making extra copies of the common pages, one in each set of docs? I think that still has a problem b

[GitHub] [iceberg-docs] kbendick commented on a change in pull request #2: Landing-Page Site and Versioned Docs Site

2021-12-21 Thread GitBox
kbendick commented on a change in pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#discussion_r773448184 ## File path: .github/workflows/deploy.yml ## @@ -0,0 +1,98 @@ +name: github pages + +on: [push, pull_request] + +jobs: + deploy-landing-page: +if: g

[GitHub] [iceberg-docs] jackye1995 commented on pull request #2: Landing-Page Site and Versioned Docs Site

2021-12-21 Thread GitBox
jackye1995 commented on pull request #2: URL: https://github.com/apache/iceberg-docs/pull/2#issuecomment-998987824 @rdblue yes I totally agree we can move forward and make incremental progress on this, that also makes the review much easier with more specific changes to look at. -- This