[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #1: First version of hugo doc site

2021-12-05 Thread GitBox
jackye1995 commented on a change in pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#discussion_r762692930 ## File path: .github/workflows/deploy.yml ## @@ -0,0 +1,52 @@ +name: github pages + +on: [push, pull_request] + +jobs: + deploy: +runs-on: ubuntu-

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

2021-12-05 Thread GitBox
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986415495 Updated to not include the javadocs and also to include the theme as a submodule. An overview of the important directories/files. - `content/docs` directory includes all o

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

2021-12-05 Thread GitBox
rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986321968 Makes sense! Let's remove whatever we can and then follow up with Javadocs in a separate commit for each version once we have the basics. That should let us review it much more ea

[GitHub] [iceberg-docs] samredai commented on pull request #1: First version of hugo doc site

2021-12-05 Thread GitBox
samredai commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986319585 Ah, my bad that's from two things: - Didn't realize I included all of the javadocs, (which accounts for 3,310 files) - I included the theme repo in this actual repo but

[GitHub] [iceberg-docs] rdblue commented on pull request #1: First version of hugo doc site

2021-12-05 Thread GitBox
rdblue commented on pull request #1: URL: https://github.com/apache/iceberg-docs/pull/1#issuecomment-986315139 Yeah, could you break this into smaller commits that we can look at? Why is this almost 3,700 files? -- This is an automated message from the Apache Git Service. To respond to t