Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Russell Spitzer
Sounds good to me. To Confirm point 3: We have unpublished version docs in Iceberg repo proper, and released version doc fixes target the new repository. > On Nov 29, 2021, at 4:34 PM, Ryan Blue wrote: > > I think that what Sam has put together is a good path forward for the docs. > > We defi

Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Jack Ye
I see, so to summarize: 1. We will only show documentation of stable releases, with the default page showing the latest stable release. 2. For fixes of existing doc, we will likely fix both in the main repo and also the latest branch of the doc repo. 3. Fixing historical doc versions could be done

Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Ryan Blue
I think the latest refers to the latest released version, not master. So the "latest" docs on the site right now would be 0.12.1. That avoids the problem of needing to copy docs from the main repo to the site repository, except by hand during a release. RYan On Mon, Nov 29, 2021 at 2:55 PM Jack Y

Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Jack Ye
Yes this is definitely a win-win! The only thing unclear to me is how we handle the latest doc. Are we going to copy the doc from main to doc repo through something like a daily job? -Jack On Mon, Nov 29, 2021 at 2:34 PM Ryan Blue wrote: > I think that what Sam has put together is a good path

Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Ryan Blue
I think that what Sam has put together is a good path forward for the docs. We definitely want to keep the latest docs in the main repository so that we can update them as part of normal pull requests. But at the same time, I think we've all had some frustration when searching through files in the

Re: Regarding the support of pluggable procedures in Iceberg

2021-11-29 Thread Ryan Murray
Ive commented on the PR with a possible way forward. Its a bit weird because of the reliance on Spark imports, I would prefer to return names or Class objects rather than the actual `Procedure` from the iceberg Catalog. Let me know what you think! Best, Ryan On Mon, Nov 29, 2021 at 2:04 PM Ryan

Re: Regarding the support of pluggable procedures in Iceberg

2021-11-29 Thread Ryan Blue
Yeah, that sounds about right. I'm not sure how we would want to do it exactly, but I think the catalog would be able to override the procedures it wants to. On Fri, Nov 26, 2021 at 9:44 AM Ryan Murray wrote: > Hey Ryan, > > Thanks for the suggestion. That makes a lot of sense. The immediate use

Re: Proposal: Switch docs site from mkdocs to hugo and relocate to a separate iceberg-docs repo

2021-11-29 Thread Kyle Bendickson
Wow, the prototype looks great, Sam! I'd like to add a little bit about possible avenues for hosting to explore and other corner areas. I only have one thing to add: 1) For the latest docs, can we consider including a warning message on the page that this is for the master version. Apache Flink