Re: Iceberg table compaction

2020-06-26 Thread Ryan Blue
Hi Chen, The "replace" operation indicates that although the files in a table changed, the actual table data did not. Queries should produce the same results, if they are deterministic. That's why we use it for file compaction: although we replace small files with fewer, smaller files, the overall

Re: failing tests on master

2020-06-26 Thread Mass Dosage
Cool, I look forward to trying it out 😀 On Fri, 26 Jun 2020, 18:56 Ryan Blue, wrote: > Yes, I think Edgar has addressed this. I have it on my list of reviews for > today. > > On Fri, Jun 26, 2020 at 10:27 AM Edgar Rodriguez > wrote: > >> There's already a fix for this in >> https://github.com/a

Re: failing tests on master

2020-06-26 Thread Ryan Blue
Yes, I think Edgar has addressed this. I have it on my list of reviews for today. On Fri, Jun 26, 2020 at 10:27 AM Edgar Rodriguez wrote: > There's already a fix for this in > https://github.com/apache/iceberg/pull/1127 > > Cheers, > > On Fri, Jun 26, 2020 at 5:26 AM Mass Dosage wrote: > >> Hel

Iceberg table compaction

2020-06-26 Thread Chen Song
Hey In Iceberg documentation, it mentions to use this for compaction . I have a few questions on compaction. Is this (replace) referring to this RewriteFiles API ? If so, i

Re: failing tests on master

2020-06-26 Thread Edgar Rodriguez
There's already a fix for this in https://github.com/apache/iceberg/pull/1127 Cheers, On Fri, Jun 26, 2020 at 5:26 AM Mass Dosage wrote: > Hello all, > > For the past week or so I've noticed failing builds on a local checkout of > master. > > I have raised an issue here: > > https://github.com/

failing tests on master

2020-06-26 Thread Mass Dosage
Hello all, For the past week or so I've noticed failing builds on a local checkout of master. I have raised an issue here: https://github.com/apache/iceberg/issues/1113 (there was initially one failing test, there are now two) Someone else raised a similar issue with one of the same failing te