Re: Review Request 55620: HIVE-15647 Combination of a boolean condition and null-safe comparison leads to NPE

2017-01-18 Thread Remus Rusanu
/ExprWalkerProcFactory.java 0338116 ql/src/test/queries/clientpositive/filter_cond_pushdown_HIVE_15647.q PRE-CREATION ql/src/test/results/clientpositive/filter_cond_pushdown_HIVE_15647.q.out PRE-CREATION Diff: https://reviews.apache.org/r/55620/diff/ Testing --- mvn test Thanks, Remus Rusanu

Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

2017-01-27 Thread Remus Rusanu
--- Thanks, Remus Rusanu

Re: Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

2017-01-30 Thread Remus Rusanu
--- Thanks, Remus Rusanu

Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-03-27 Thread Remus Rusanu
, Remus Rusanu

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-04-11 Thread Remus Rusanu
/vector_string_decimal.q.out 3540635 Diff: https://reviews.apache.org/r/57944/diff/2/ Changes: https://reviews.apache.org/r/57944/diff/1-2/ Testing --- Thanks, Remus Rusanu

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

2017-04-13 Thread Remus Rusanu
78line5> > > > > This is not expected. This is caused by https://issues.apache.org/jira/browse/HIVE-16317 - Remus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Review Request 58531: HIVE-16317 CASE .. NULL in JOIN condition can trigger SemanticException

2017-04-19 Thread Remus Rusanu
ive/ql/parse/SemanticAnalyzer.java 77fc35d ql/src/test/results/clientpositive/perf/query31.q.out 4de6eb6 Diff: https://reviews.apache.org/r/58531/diff/1/ Testing --- Thanks, Remus Rusanu

Review Request 59624: HIVE-16757 remove use of deperecated RelNode.getRows()

2017-05-29 Thread Remus Rusanu
--- Thanks, Remus Rusanu

Re: Review Request 59624: HIVE-16757 remove use of deperecated RelNode.getRows()

2017-05-30 Thread Remus Rusanu
://reviews.apache.org/r/59624/diff/2/ Changes: https://reviews.apache.org/r/59624/diff/1-2/ Testing --- Thanks, Remus Rusanu

Re: Review Request 59624: HIVE-16757 remove use of deperecated RelNode.getRows()

2017-05-30 Thread Remus Rusanu
://reviews.apache.org/r/59624/diff/3/ Changes: https://reviews.apache.org/r/59624/diff/2-3/ Testing --- Thanks, Remus Rusanu

Re: Review Request: Extend vectorized Group By aggregates to support keys

2013-05-20 Thread Remus Rusanu
ing --- New unit tests added for aggregated expressions with keys, including null keys. Thanks, Remus Rusanu

Review Request: "C:\Users\remusr\Downloads\HIVE-4450-p1.patch.txt"

2013-05-20 Thread Remus Rusanu
ons/TestConstantVectorExpression.java f2e5399 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeCaptureOutputOperator.java e4cd0b6 Diff: https://reviews.apache.org/r/11239/diff/ Testing --- New unit tests added for aggregated expressions with keys, including null keys. Thanks, Remus Rusanu

Re: Review Request: HIVE-4450 Extend vectorized Group By aggregates to support keys

2013-05-20 Thread Remus Rusanu
iff/ Testing --- New unit tests added for aggregated expressions with keys, including null keys. Thanks, Remus Rusanu

Review Request: HIVE-4160 Add support for string type keys in vectorized GROUP BY

2013-05-23 Thread Remus Rusanu
it test to cover String keys for some cases. Thanks, Remus Rusanu

Re: Review Request: HIVE-4595 Add support for string type keys in vectorized GROUP BY

2013-05-23 Thread Remus Rusanu
op/hive/ql/exec/vector/util/FakeVectorRowBatchFromLongIterables.java PRE-CREATION Diff: https://reviews.apache.org/r/11345/diff/ Testing --- Extended vectorized GROUP BY unit test to cover String keys for some cases. Thanks, Remus Rusanu

Re: Review Request: HIVE-4595 Add support for string type keys in vectorized GROUP BY

2013-05-24 Thread Remus Rusanu
iff: https://reviews.apache.org/r/11345/diff/ Testing --- Extended vectorized GROUP BY unit test to cover String keys for some cases. Thanks, Remus Rusanu

Review Request: HIVE-4451 support COUNT/MIN/MAX aggregates on string types

2013-05-25 Thread Remus Rusanu
/VectorUDAFMinMaxString.txt PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java b3b5cd2 Diff: https://reviews.apache.org/r/11425/diff/ Testing --- UT added, manually tested query in hive-cli Thanks, Remus Rusanu

Review Request: Support COUNT(*) in vectorized aggregates

2013-05-25 Thread Remus Rusanu
-CREATION ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java b3b5cd2 Diff: https://reviews.apache.org/r/11426/diff/ Testing --- New UT added, manually tested in hive-cli Thanks, Remus Rusanu

Re: Review Request: HIVE-4452 Support COUNT(*) in vectorized aggregates

2013-05-25 Thread Remus Rusanu
UT added, manually tested in hive-cli Thanks, Remus Rusanu

Review Request: HIVE-4612 Fix vector aggregates int type key output

2013-05-25 Thread Remus Rusanu
/src/java/org/apache/hadoop/hive/ql/exec/VectorHashKeyWrapperBatch.java c23614c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 1ef4955 Diff: https://reviews.apache.org/r/11427/diff/ Testing --- manual test query Thanks, Remus Rusanu

Re: Review Request: HIVE-4612 Fix vector aggregates int type key output

2013-05-25 Thread Remus Rusanu
, Remus Rusanu

Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type

2013-05-31 Thread Remus Rusanu
, Remus Rusanu

Re: Review Request: HIVE-4612 Fix vector aggregates int type key output

2013-06-03 Thread Remus Rusanu
/FakeVectorRowBatchFromObjectIterables.java 6824ee7 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 6fc230f Diff: https://reviews.apache.org/r/11427/diff/ Testing --- manual test query Thanks, Remus Rusanu

Review Request: HIVE-4651 TestVectorGroupByOperator causes asserts in StandardStructObjectInspector.init

2013-06-04 Thread Remus Rusanu
/r/11624/diff/ Testing --- Thanks, Remus Rusanu

Review Request: HIVE-4652 VectorHashKeyWrapperBatch.java should be in vector package (instead of exec)

2013-06-04 Thread Remus Rusanu
/exec/vector/VectorHashKeyWrapperBatch.java PRE-CREATION Diff: https://reviews.apache.org/r/11625/diff/ Testing --- Thanks, Remus Rusanu

Re: Review Request: HIVE-4637 Fix VectorUDAFSum.txt to honor the expected vector column type

2013-06-04 Thread Remus Rusanu
/templates/VectorUDAFSum.txt 6ad ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 42cdcf4 Diff: https://reviews.apache.org/r/11579/diff/ Testing --- Added new UT to cover this case Thanks, Remus Rusanu

Review Request: HIVE-4606 Add memory pressure flush for VectorGroupByOperator

2013-06-08 Thread Remus Rusanu
c4e6a19 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFVar.txt 9c8ad94 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 0050ebc Diff: https://reviews.apache.org/r/11747/diff/ Testing --- Thanks, Remus Rusanu

Re: Review Request: HIVE-4606 Add memory pressure flush for VectorGroupByOperator

2013-06-11 Thread Remus Rusanu
/r/11747/diff/ Testing --- Thanks, Remus Rusanu

Review Request: HIVE-4686 Fix output object type for min/max aggregates, preserver input expression type. also fix null output to use NullWritable

2013-06-12 Thread Remus Rusanu
--- Unit test updated, manual repro dataset verification Thanks, Remus Rusanu

Review Request: HIVE-4716 the VectorHashKeyWrapper is using a plain wrong column index for string values

2013-06-13 Thread Remus Rusanu
l/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java 70e3cfd ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java 669946d Diff: https://reviews.apache.org/r/11857/diff/ Testing --- repro case tested Thanks, Remus Rusanu

Review Request: HIVE-4718 Incorrect handling of string keys and null values in VectorHashKey

2013-06-19 Thread Remus Rusanu
tests added Thanks, Remus Rusanu

Review Request 12132: HIVE-4774 Hive Runtime Error while closing operators: java.lang.NullPointerException

2013-06-27 Thread Remus Rusanu
/VectorExpressionWriterFactory.java b041fc5 Diff: https://reviews.apache.org/r/12132/diff/ Testing --- Manually run repro case. Thanks, Remus Rusanu

Review Request 12133: HIVE-4786 Incorrect aggregate results

2013-06-27 Thread Remus Rusanu
, Remus Rusanu

Review Request 12939: HIVE-4931 MAX/MIN aggregates yield incorrect results

2013-07-25 Thread Remus Rusanu
Thanks, Remus Rusanu

Review Request 13059: HIVE-4850 Implement vector mode map join

2013-07-30 Thread Remus Rusanu
some join queries on alltypes_orc table. Thanks, Remus Rusanu

A question about SMB join and the MapWork pathToPartitionInfo/pathToAliases: considered 'local' plan for the 'small' SMB aliases

2013-12-04 Thread Remus Rusanu
Hi all, I'm working on HIVE-5595 to add vectorization support for SMB join operators. The problem I'm facing is that the vectorized record readers (eg. VectorizedOrcRecordReader) have a dependency on the MapWork.pathToPartitionInfo (see VectorizedRowBatchCtx.init). What I discovered though is

Review Request 16167: HIVE-5595 Implement Vectorized SMB Join

2013-12-10 Thread Remus Rusanu
: https://reviews.apache.org/r/16167/diff/ Testing --- New .q file, manually tested several cases Thanks, Remus Rusanu

Re: Review Request 16167: HIVE-5595 Implement Vectorized SMB Join

2013-12-10 Thread Remus Rusanu
/vectorized_bucketmapjoin1.q PRE-CREATION ql/src/test/results/clientpositive/vectorized_bucketmapjoin1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16167/diff/ Testing --- New .q file, manually tested several cases Thanks, Remus Rusanu

Re: Review Request 16167: HIVE-5595 Implement Vectorized SMB Join

2014-01-13 Thread Remus Rusanu
/vectorized_bucketmapjoin1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16167/diff/ Testing --- New .q file, manually tested several cases Thanks, Remus Rusanu

Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-05 Thread Remus Rusanu
Diff: https://reviews.apache.org/r/17737/diff/ Testing --- New unit tests added, manually tested decimal GBY queries Thanks, Remus Rusanu

Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-05 Thread Remus Rusanu
/17737/diff/ Testing --- New unit tests added, manually tested decimal GBY queries Thanks, Remus Rusanu

How is the STORED AS PARQUET used?

2014-02-05 Thread Remus Rusanu
Hello all, I tried the following on a build that has the latest HIVE-5783 patch applied over trunk: hive> set hive.aux.jars.path=file:///usr/lib/hcatalog/share/hcatalog/hcatalog-core.jar,file:///usr/lib/hive/lib/parquet-hadoop-bundle-1.3.2.jar; hive> create table alltypes_parquet stored as parq

RE: How is the STORED AS PARQUET used?

2014-02-05 Thread Remus Rusanu
Feb 5, 2014 at 8:27 AM, Remus Rusanu wrote: > Hello all, > > I tried the following on a build that has the latest HIVE-5783 patch applied > over trunk: > > hive> set > hive> hive.aux.jars.path=file:///usr/lib/hcatalog/share/hcatalog/hcata > hive> log-core.jar,file:///

Any way to preserve the .q unit tests MR execution output?

2014-02-06 Thread Remus Rusanu
When running a test that fails, I can get the output diff and the hive log, but when the failure occurs in the query execution, I don't see how I can retrieve whatever was logged by the execution. For example, I can see in the target\qfile-results\...q.out: PREHOOK: query: SELECT cint, .

RE: Any way to preserve the .q unit tests MR execution output?

2014-02-08 Thread Remus Rusanu
34 PM, Remus Rusanu wrote: > When running a test that fails, I can get the output diff and the hive log, > but when the failure occurs in the query execution, I don't see how I can > retrieve whatever was logged by the execution. > > For example, I can see in the targ

RE: Any way to preserve the .q unit tests MR execution output?

2014-02-09 Thread Remus Rusanu
way to preserve the .q unit tests MR execution output? I just ran a test on my local machine and the MR logs went to /tmp/brock. Brock On Sat, Feb 8, 2014 at 6:12 AM, Remus Rusanu wrote: > Thanks Brock, > > I do get a MR folder structure, like > > test/target/tmp/hadoop-tmp//mapre

Is this a typo in MapRedLocal or intentional?

2014-02-09 Thread Remus Rusanu
At @328:? if (environmentVariables.get(HIVE_DEBUG_RECURSIVE).equals("y")) { // swap debug options in HADOOP_CLIENT_OPTS to those that the child JVM should have assert environ

RE: Is this a typo in MapRedLocal or intentional?

2014-02-10 Thread Remus Rusanu
I created HIVE-6398 and uploaded a patch https://issues.apache.org/jira/browse/HIVE-6398 -Original Message- From: Remus Rusanu [mailto:rem...@microsoft.com] Sent: Sunday, February 09, 2014 11:24 PM To: hive-...@hadoop.apache.org Subject: Is this a typo in MapRedLocal or intentional? At

Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files

2014-02-10 Thread Remus Rusanu
hadoop/hive/ql/io/parquet/VectorizedParquetInputFormat.java PRE-CREATION Diff: https://reviews.apache.org/r/17899/diff/ Testing --- Manually tested. I will add .q query but I need to get home (to my Mac) where I can actually run tests and create expected output(s). Thanks, Remus Rusanu

Pre-commit builds are all failing past 2 days

2014-02-11 Thread Remus Rusanu
* Last successful build (#1262), 2 days 2 hr ago? I had a couple of patches uploaded yesterday and for both I got the red -1, but then I noticed all pre-commit builds are failing. What's going on?

Re: Review Request 13059: HIVE-4850 Implement vector mode map join

2013-10-03 Thread Remus Rusanu
/MapWork.java a72ec8b Diff: https://reviews.apache.org/r/13059/diff/ Testing --- Manually run some join queries on alltypes_orc table. Thanks, Remus Rusanu

Re: Review Request 13059: HIVE-4850 Implement vector mode map join

2013-10-03 Thread Remus Rusanu
/apache/hadoop/hive/ql/plan/MapWork.java a72ec8b Diff: https://reviews.apache.org/r/13059/diff/ Testing --- Manually run some join queries on alltypes_orc table. Thanks, Remus Rusanu

Re: Review Request 13059: HIVE-4850 Implement vector mode map join

2013-10-09 Thread Remus Rusanu
/clientpositive/vectorized_mapjoin.q.out PRE-CREATION Diff: https://reviews.apache.org/r/13059/diff/ Testing --- Manually run some join queries on alltypes_orc table. Thanks, Remus Rusanu

Re: Review Request 13059: HIVE-4850 Implement vector mode map join

2013-10-12 Thread Remus Rusanu
/clientpositive/vectorized_mapjoin.q.out PRE-CREATION Diff: https://reviews.apache.org/r/13059/diff/ Testing --- Manually run some join queries on alltypes_orc table. Thanks, Remus Rusanu

Review Request 15095: Make the VectorGroupByOperator memory pressure factors configurable

2013-10-30 Thread Remus Rusanu
: https://reviews.apache.org/r/15095/diff/ Testing --- Added new unit test Thanks, Remus Rusanu

Re: Review Request 15095: Make the VectorGroupByOperator memory pressure factors configurable

2013-10-30 Thread Remus Rusanu
/TestVectorGroupByOperator.java d1d2ea9 Diff: https://reviews.apache.org/r/15095/diff/ Testing --- Added new unit test Thanks, Remus Rusanu

RE: Review Request 13059: HIVE-4850 Implement vector mode map join

2013-11-11 Thread Remus Rusanu
endra Pandey; Eric Hanson (SQL SERVER) Cc: Remus Rusanu; hive Subject: Re: Review Request 13059: HIVE-4850 Implement vector mode map join --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/

Re: Review Request 15594: OutputOI need to be passed.

2013-11-15 Thread Remus Rusanu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15594/#review28991 --- Ship it! - Remus Rusanu On Nov. 15, 2013, 9:33 p.m., Ashutosh

How do you run single query test(s) after mavenization?

2013-11-18 Thread Remus Rusanu
I'm trying to run as per the updated Contributing guide: mvn test -Dtest=TestCliDriver "-Dqfile=vectorized_mapjoin.q" (The guide actually recommends -Dcase=TestCliDriver but using -Dcase executes all tests. In fac

RE: How do you run single query test(s) after mavenization?

2013-11-18 Thread Remus Rusanu
va:317) at org.apache.hadoop.hive.cli.TestCliDriver.(TestCliDriver.java:39) From: Remus Rusanu [mailto:rem...@microsoft.com] Sent: Monday, November 18, 2013 2:30 PM To: dev@hive.apache.org Cc: Ashutosh Chauhan; Tony Murphy (HDINSIGHT); Eric Hanson (SQL SERVER) Subject: How do you run single query test(s) after

HowTo: Debugging/Running localmode on YARN ?

2013-11-19 Thread Remus Rusanu
Hello all, I just discovered that with 23 shims the localmode is driven by SET mapreduce.framework.name=local; not by the traditional SET mapred.job.tracker=local; Has anyone put together a how-to for debugging/running localmode on Yarn, like Thejas had for classic Hadoop at http://hadoop-pi

Review Request 15716: HIVE-5845 CTAS failed on vectorized code path

2013-11-20 Thread Remus Rusanu
/TestVectorExpressionWriters.java 1899c3b Diff: https://reviews.apache.org/r/15716/diff/ Testing --- Repro, new unit tests Thanks, Remus Rusanu

Review Request 15849: HIVE-5817 column name to index mapping in VectorizationContext is broken

2013-11-25 Thread Remus Rusanu
/Vectorizer.java 151c648 Diff: https://reviews.apache.org/r/15849/diff/ Testing --- Thanks, Remus Rusanu

Why is the test hive-log4j.properties attempting to init an FTP logger?? (Windows)

2013-11-28 Thread Remus Rusanu
When I try to run the TestCliDriver, I get this in the -output.txt: log4j: Using URL [file://E:/HW/project/hive-monarch/itests/qtest/target/tmp/conf/hive-log4j.properties] for automatic log4j configuration. log4j: Reading configuration from URL file://E:/HW/project/hive-monarch/itests/qtest/tar

What determines the shims used during testing?

2013-11-28 Thread Remus Rusanu
On my Windows system test fail as Context.getScratchDir fails: java.io.IOException: Failed to set permissions of path: \HW\project\hive-monarch\itests\qtest\target\tmp\scratchdir\hive_2013-11-28_16-20-53_995_395869757529987755-1 to 0700 at org.apache.hadoop.fs.FileUtil.checkRetu

RE: What determines the shims used during testing?

2013-11-29 Thread Remus Rusanu
D'oh! Of course is add -Dhadoop-20S.version=1.3.0-SNAPSHOT So it picks my Hadoop version of choice (also -Phadoop-1 now). Thanks, ~Remus -Original Message- From: Remus Rusanu [mailto:rem...@microsoft.com] Sent: Thursday, November 28, 2013 4:44 PM To: hive-...@hadoop.apache.org Su

RE: Pre-commit builds are all failing past 2 days

2014-02-11 Thread Remus Rusanu
ra.org:8080/job/PreCommit-HIVE-Build/1270/ two tests failed. However, it was just stuck testing HIVE-6254. I restarted the test server. Brock On Tue, Feb 11, 2014 at 2:52 AM, Remus Rusanu wrote: > * Last successful build (#1262), 2 days 2 hr ago< > http://bigtop01.cloudera.org:8080/

Re: Review Request 17737: Add DECIMAL support to vectorized group by operator

2014-02-12 Thread Remus Rusanu
ted in a comment, and did so. - Remus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17737/#review33964 --- On Feb.

Review Request 18002: Add DECIMAL support to vectorized JOIN operators and vectorized aggregates

2014-02-12 Thread Remus Rusanu
: https://reviews.apache.org/r/18002/diff/ Testing --- Manual, new units, new .q/.out Thanks, Remus Rusanu

Incompatibilities between metadata types and actual values read by the Parquet input format

2014-02-12 Thread Remus Rusanu
While working on HIVE-5998 I noticed that the ParquetRecordReader returns IntWritable for all 'int like' types, in disaccord with the row object inspectors. I though fine, and I worked my way around it. But I see now that the issue trigger failuers in other places, eg. in aggregates: Caused by:

RE: Incompatibilities between metadata types and actual values read by the Parquet input format

2014-02-12 Thread Remus Rusanu
Done. https://issues.apache.org/jira/browse/HIVE-6414 Thanks, ~Remus From: Brock Noland [mailto:br...@cloudera.com] Sent: Wednesday, February 12, 2014 6:15 PM To: Remus Rusanu Cc: dev@hive.apache.org Subject: Re: Incompatibilities between metadata types and actual values read by the Parquet

Re: Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files

2014-02-13 Thread Remus Rusanu
/diff/ Testing (updated) --- Manually tested. New query .q added. Thanks, Remus Rusanu

Re: Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files

2014-02-13 Thread Remus Rusanu
--- Manually tested. New query .q added. Thanks, Remus Rusanu

Re: Review Request 18002: Add DECIMAL support to vectorized JOIN operators and vectorized aggregates

2014-02-13 Thread Remus Rusanu
/TestHiveDecimalWritable.java PRE-CREATION Diff: https://reviews.apache.org/r/18002/diff/ Testing --- Manual, new units, new .q/.out Thanks, Remus Rusanu

Review Request 18071: bug in high-precision Decimal128 multiply

2014-02-13 Thread Remus Rusanu
Diff: https://reviews.apache.org/r/18071/diff/ Testing --- regression test case added Thanks, Remus Rusanu

Re: Review Request 18071: bug in high-precision Decimal128 multiply

2014-02-14 Thread Remus Rusanu
/hive/common/type/TestDecimal128.java 6824cd7 Diff: https://reviews.apache.org/r/18071/diff/ Testing --- regression test case added Thanks, Remus Rusanu

Re: Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files

2014-02-14 Thread Remus Rusanu
g/r/17899/diff/ Testing --- Manually tested. New query .q added. Thanks, Remus Rusanu

A question about the derivation of intermediate sum field for decimal average aggregates

2014-02-14 Thread Remus Rusanu
Hi, With HIVE-5872 the intermediate sum field for decimal aggregates was changed to increase scale by 4. I understand the reasoning for having accurate precision/scale for the aggregate output. However, for the intermediate sum field of AVG, I believe we should increase precision w/o increasing

RE: Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files

2014-02-14 Thread Remus Rusanu
Noland Cc: Remus Rusanu; hive Subject: Re: Review Request 17899: HIVE-5998 Add vectorized reader for Parquet files This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17899/ Seems fine to me! Someone familiar with vectorization should probably do the +1

RE: A question about the derivation of intermediate sum field for decimal average aggregates

2014-02-14 Thread Remus Rusanu
ve tables. Thus, I'm not sure if truncating data before it's summed if the right behavior. Do you have a use case that suggests one is better than the other? --Xuefu On Fri, Feb 14, 2014 at 3:55 AM, Remus Rusanu wrote: > Hi, > > With HIVE-5872 the intermediate sum field f

RE: A question about the derivation of intermediate sum field for decimal average aggregates

2014-02-15 Thread Remus Rusanu
, Xuefu On Fri, Feb 14, 2014 at 2:09 PM, Remus Rusanu wrote: > Hi Xuefu, > > I do not have any particular use case in mind. I've noticed the > problem when I implemented the vectorized AVG for decimal, which must > match your implementation (since we vectorized only the map

Why do I get statistics diff in EXPLAIN for Parquet?

2014-02-17 Thread Remus Rusanu
Looking at the failed Jenkins runs for HIVE-5998, I see there are diffs in the statistics in the EXPLAIN: Running: diff -a /root/hive/itests/qtest/../../itests/qtest/target/qfile-results/clientpositive/vectorized_parquet.q.out /root/hive/itests/qtest/../../ql/src/test/results/clientpositive/ve

RE: Why do I get statistics diff in EXPLAIN for Parquet?

2014-02-17 Thread Remus Rusanu
OK, so I get the similar diffs with ORC, so is not Parquet. The expected .out files are created running mvn test on Windows, so the issue is Windows specific not Parquet specific. I'll investigate... From: Remus Rusanu [mailto:rem...@microsoft.com] Sent: Monday, February 17, 2014 3:59

RE: [ANNOUNCE] New Hive Committer - Remus Rusanu

2014-02-26 Thread Remus Rusanu
Thanks everybody, I'm really happy for this. This was one of the best 'check email from home' days ;) From: Gunther Hagleitner Sent: Wednesday, February 26, 2014 9:47 PM To: dev@hive.apache.org Subject: Re: [ANNOUNCE] New Hive Committer

RE: [ANNOUNCE] New Hive PMC Member - Xuefu Zhang

2014-02-28 Thread Remus Rusanu
Grats! From: Prasanth Jayachandran Sent: Friday, February 28, 2014 9:11 PM To: dev@hive.apache.org Cc: u...@hive.apache.org; Xuefu Zhang Subject: Re: [ANNOUNCE] New Hive PMC Member - Xuefu Zhang Congratulations Xuefu! Thanks Prasanth Jayachandran On Feb

hive script when invoked through a link

2014-03-05 Thread Remus Rusanu
I tried making /usr/bin/hive a link to /usr/lib/hive-0.14/bin/hive . But the launch fails because: bin=`dirname "$0"` bin=`cd "$bin"; pwd` . "$bin"/hive-config.sh So I used a readlink -f first, to locate the proper script home, and then it works fine. My question is: is this kind of problem so

RE: hive script when invoked through a link

2014-03-05 Thread Remus Rusanu
This should be fixed on trunk. I believe we want to use the BAS_SOURCE environment variable. On Mar 5, 2014 3:22 AM, "Remus Rusanu" wrote: > I tried making /usr/bin/hive a link to /usr/lib/hive-0.14/bin/hive . > But the launch fails because: > > bin=`dirname "$0"

Review Request 18943: Make Vector Group By operator abandon grouping if too many distinct keys

2014-03-08 Thread Remus Rusanu
--- Manually tested. I plan to add test cases in TestVGBy Thanks, Remus Rusanu

Re: Review Request 18943: Make Vector Group By operator abandon grouping if too many distinct keys

2014-03-18 Thread Remus Rusanu
0089ad3 Diff: https://reviews.apache.org/r/18943/diff/ Testing --- Manually tested. I plan to add test cases in TestVGBy Thanks, Remus Rusanu

HIVE 4381: how to amend a phabricator review?

2013-04-22 Thread Remus Rusanu
Hello All, My CR request for https://issues.apache.org/jira/browse/HIVE-4381 includes some files I did not intend to include in the commit (eg. /.arcanist, /.checkstyle and /build.xml changes) What is the proper procedure (git, JIRA and phabricator) to amend the patch? Thanks, ~Remus

[jira] [Commented] (HIVE-7845) "Failed to locate the winutils binary" when loading JDBC driver on Windows

2014-08-26 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110616#comment-14110616 ] Remus Rusanu commented on HIVE-7845: I created HADOOP-11003 to

[jira] [Commented] (HIVE-8106) Enable vectorization for spark [spark branch]

2014-09-17 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136959#comment-14136959 ] Remus Rusanu commented on HIVE-8106: Can you add review board link? ty >

[jira] [Commented] (HIVE-7664) VectorizedBatchUtil.addRowToBatchFrom is not optimized for Vectorized execution and takes 25% CPU

2014-08-19 Thread Remus Rusanu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102204#comment-14102204 ] Remus Rusanu commented on HIVE-7664: shouldn't there be a case for DECIMAL

[jira] [Created] (HIVE-15647) Combination of a boolean condition and null-safe comparison leads to NPE

2017-01-17 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-15647: --- Summary: Combination of a boolean condition and null-safe comparison leads to NPE Key: HIVE-15647 URL: https://issues.apache.org/jira/browse/HIVE-15647 Project: Hive

[jira] [Created] (HIVE-15723) Hive should report a warning about missing table/column statistics to user.

2017-01-25 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-15723: --- Summary: Hive should report a warning about missing table/column statistics to user. Key: HIVE-15723 URL: https://issues.apache.org/jira/browse/HIVE-15723 Project

[jira] [Created] (HIVE-16027) BETWEEN AND must cast to TIMESTMAP

2017-02-23 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-16027: --- Summary: BETWEEN AND must cast to TIMESTMAP Key: HIVE-16027 URL: https://issues.apache.org/jira/browse/HIVE-16027 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-16173) NPE in HiveMaterializedViewsRegistry.dropMaterializedView when dropping MV from CLI

2017-03-10 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-16173: --- Summary: NPE in HiveMaterializedViewsRegistry.dropMaterializedView when dropping MV from CLI Key: HIVE-16173 URL: https://issues.apache.org/jira/browse/HIVE-16173

[jira] [Created] (HIVE-16317) CASE .. NULL in JOIN condition can trigger SemanticException

2017-03-28 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-16317: --- Summary: CASE .. NULL in JOIN condition can trigger SemanticException Key: HIVE-16317 URL: https://issues.apache.org/jira/browse/HIVE-16317 Project: Hive

[jira] [Created] (HIVE-16358) Push TOP N to Druid queries

2017-04-03 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-16358: --- Summary: Push TOP N to Druid queries Key: HIVE-16358 URL: https://issues.apache.org/jira/browse/HIVE-16358 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-16438) Support inclusive sort order on ReduceDink deduplication

2017-04-13 Thread Remus Rusanu (JIRA)
Remus Rusanu created HIVE-16438: --- Summary: Support inclusive sort order on ReduceDink deduplication Key: HIVE-16438 URL: https://issues.apache.org/jira/browse/HIVE-16438 Project: Hive Issue

  1   2   3   4   5   6   >