Re: [DISCUSS] Hive Support

2024-11-27 Thread Denys Kuzmenko
Hi Gabor, It's a bit odd to get the following feedback from the Impala folks: "I'd like to understand the motivation why this whole replication of code happened between Iceberg and Hive." when you know exactly why. FYI, we've raised our concerns multiple times to the iceberg community, for ex

Re: [DISCUSS] Hive Support

2024-11-27 Thread Ayush Saxena
> Let me know if the above doesn't make any sense, though! To be honest, it doesn’t. The email feels accusatory, unfairly blaming the Hive community for wrongdoing while portraying the Iceberg folks as "worse" and insinuating misconduct on their part. This kind of tone does nothing to foster conse

Re: [DISCUSS] Hive Support

2024-11-27 Thread Ayush Saxena
> Let me know if the above doesn't make any sense, though! To be honest, it doesn’t. The email feels accusatory, unfairly blaming the Hive community for wrongdoing while portraying the Iceberg folks as "worse" and insinuating misconduct on their part. This kind of tone does nothing to foster conse

Re: [DISCUSS] Hive Support

2024-11-27 Thread rdb...@gmail.com
I think that we should remove Hive 2 and Hive 3. We already agreed to remove Hive 2, but Hive 3 is not compatible with the project anymore and is already EOL and will not see a release to update it so that it can be compatible. Anyone using the existing Hive 3 support should be able to continue usi

Re: [DISCUSS] Hive Support

2024-11-27 Thread Fokko Driesprong
Hey Cheng, Thanks for the suggestion. The nightly snapshots are available: https://repository.apache.org/content/groups/snapshots/org/apache/iceberg/iceberg-core/, which might help when working on features that are not released yet (eg Nanosecond timestamps). Besides that, we should run RCs agains

Re: [DISCUSS] Hive Support

2024-11-27 Thread Cheng Pan
> That said, it would be helpful if they continue running > tests against the latest stable Hive releases to ensure that any > changes don’t unintentionally break something for Hive, which would be > beyond our control. > I believe we should continue maintaining a Hive Iceberg runtime test suite

Re: [Discuss] Should we remove the auto-assign reviewer github-actions?

2024-11-27 Thread Butao Zhang
Thanks Ayush&Stamatis for your input! I have created the ticket to remove the auto-assign github-actions. Please check it. Thx. https://issues.apache.org/jira/browse/HIVE-28647 https://github.com/apache/hive/pull/5564 Thanks, Butao Zhang On 2024/11/25 08:44:28 Stamatis Zampetakis wrote: > In

Re: [DISCUSS] Hive Support

2024-11-27 Thread Gabor Kaszab
Hi All, As I see there is a general opinion on not keeping the Hive code in the Iceberg repo, but maintaining a set of tests that verifies the actual Iceberg code against the latest Hive release. For me it would seem a bit odd to maintain a test suite for verifying some code that is not maintained