Re: [DISCUSS] Hive Support

2024-11-25 Thread Péter Váry
Let's separate out the discussion of the 2 modules: - hive-metastore - we definitely need the implementation and the tests here, as we want to be able to progress with features like views without waiting for a Hive release. So we need to move forward to Hive 4 now, and keep the code in place - hive

Re: [DISCUSS] Hive Support

2024-11-25 Thread Denys Kuzmenko
Hi Peter, Thanks for bringing it up! I think that option 1 is the only viable solution here (remove the hive-runtime from the iceberg repo). Main reason: lack of reviewers for things other than Spark. Note: need to double check, but I am pretty sure there is no difference between Hive `iceb

Re: [DISCUSS] Hive Support

2024-11-25 Thread Ayush Saxena
Hi Peter, Thanks for bringing this to our attention. >From my side, I have a say only on the code that resides in the Hive repository. I am okay with the first approach, as we are already following it for the most part. Whether Iceberg keeps or drops the code shouldn’t have much impact on us. (I

Re: [DISCUSS] Hive Support

2024-11-25 Thread Wing Yew Poon
For the Hive runtime, would it be feasible for the Hive community to contribute a suite of tests to the Iceberg repo that can be run with dependencies from the latest Hive release (Hive 4.x), and then update them from time to time as appropriate? The purpose of this suite would be to test integrati

Re: [Discuss] Should we remove the auto-assign reviewer github-actions?

2024-11-25 Thread Stamatis Zampetakis
In the past it was used by some people but I guess it's not the case anymore. It could be a helpful feature but if noone is using it then we can definitely drop it. If needed we can bring it back again later on. Best, Stamatis On Sun, Nov 24, 2024 at 9:35 AM Ayush Saxena wrote: > > +1, that was

Re: Iceberg branching tagging syntax

2024-11-25 Thread Okumin
Hi Attila, Adding new commands could be an option. Honestly, I don't often use BRANCH or TAG, and I don't have a strong opinion on either approach. Off topic. If I understand correctly, Dremio's branching semantics are different from what Hive provides. Dremio supports versioning not per table bu

Re: [DISCUSS] Hive Support

2024-11-25 Thread Butao Zhang
Hi folks, Firstly Thanks Peter for bringing it up! I also think option 1 is a more reasonable solution right now, as we have developed lots of advanced iceberg features in hive repo, such as mor & cow & compaction, etc, and these feats are coupled with Hive core code base. Hive r