Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/ --- Review request for hive and cheng xu. Repository: hive-git Description --

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/#review149796 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1863)

Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- Review request for hive, Gabor Szadovszky, Peter Vary, Sergio Pena, and Szehon H

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/#review149800 --- ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java (line 35)

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/#review149801 --- Thanks a lot for the patch. I had just some minor hints. - Marta

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149810 --- Thanks for the patch. One minor finding and a question: At many pl

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149805 --- Thanks Zsombor! Godd refactor, just minor nits, and some question

[jira] [Created] (HIVE-14804) HPLSQL multiple db connection does not switch back to Hive

2016-09-21 Thread Dmitry Kozlov (JIRA)
Dmitry Kozlov created HIVE-14804: Summary: HPLSQL multiple db connection does not switch back to Hive Key: HIVE-14804 URL: https://issues.apache.org/jira/browse/HIVE-14804 Project: Hive Issue

Review Request 52122: HIVE-9423 - HiveServer2: Implement some admission control mechanism for graceful degradation when resources are exhausted

2016-09-21 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52122/ --- Review request for hive, Aihua Xu, Marta Kuczora, Miklos Csanady, Sergio Pena, V

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- (Updated Sept. 21, 2016, 3:19 p.m.) Review request for hive, Gabor Szadovszky,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
> On Sept. 21, 2016, 12:16 p.m., Gabor Szadovszky wrote: > > Thanks for the patch. > > One minor finding and a question: > > At many places you have refactored to throw unchecked exceptions instead of > > checked ones while removed the catch blocks of the checked ones. Are you > > sure it canno

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- (Updated Sept. 21, 2016, 3:20 p.m.) Review request for hive, Gabor Szadovszky,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149828 --- LGTM, thanks for the patch - Peter Vary On Sept. 21, 2016, 3:20

Re: Review Request 52122: HIVE-9423 - HiveServer2: Implement some admission control mechanism for graceful degradation when resources are exhausted

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52122/#review149826 --- Ship it! +1, just some typos. Thanks for the patch. beeline/s

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149832 --- Ship it! Thanks, LGTM. - Gabor Szadovszky On Sept. 21, 2016,

[jira] [Created] (HIVE-14805) Subquery inside a view doesn't set InsideView property correctly

2016-09-21 Thread Aihua Xu (JIRA)
Aihua Xu created HIVE-14805: --- Summary: Subquery inside a view doesn't set InsideView property correctly Key: HIVE-14805 URL: https://issues.apache.org/jira/browse/HIVE-14805 Project: Hive Issue Ty

[jira] [Created] (HIVE-14806) Support UDTF in CBO (AST return path)

2016-09-21 Thread Pengcheng Xiong (JIRA)
Pengcheng Xiong created HIVE-14806: -- Summary: Support UDTF in CBO (AST return path) Key: HIVE-14806 URL: https://issues.apache.org/jira/browse/HIVE-14806 Project: Hive Issue Type: Sub-task

Review Request 52127: Support UDTF in CBO (AST return path)

2016-09-21 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52127/ --- Review request for hive and Ashutosh Chauhan. Repository: hive-git Descriptio

[jira] [Created] (HIVE-14807) analyze table compute statistics fails due to presence of Infinity value in double column

2016-09-21 Thread Edi Bice (JIRA)
Edi Bice created HIVE-14807: --- Summary: analyze table compute statistics fails due to presence of Infinity value in double column Key: HIVE-14807 URL: https://issues.apache.org/jira/browse/HIVE-14807 Project

[jira] [Created] (HIVE-14808) Support TRUNCATE in tez

2016-09-21 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-14808: Summary: Support TRUNCATE in tez Key: HIVE-14808 URL: https://issues.apache.org/jira/browse/HIVE-14808 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-14809) Support ARCHIVE/UNARCHIVE in tez

2016-09-21 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-14809: Summary: Support ARCHIVE/UNARCHIVE in tez Key: HIVE-14809 URL: https://issues.apache.org/jira/browse/HIVE-14809 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-14810) Failing test: TestMetaStoreMetrics.testMetaDataCounts

2016-09-21 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-14810: - Summary: Failing test: TestMetaStoreMetrics.testMetaDataCounts Key: HIVE-14810 URL: https://issues.apache.org/jira/browse/HIVE-14810 Project: Hive Issue Ty

[jira] [Created] (HIVE-14811) Failing test: TestCliDriver ctas

2016-09-21 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-14811: - Summary: Failing test: TestCliDriver ctas Key: HIVE-14811 URL: https://issues.apache.org/jira/browse/HIVE-14811 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14812) Failing test: TestCliDriver acid_mapjoin

2016-09-21 Thread Siddharth Seth (JIRA)
Siddharth Seth created HIVE-14812: - Summary: Failing test: TestCliDriver acid_mapjoin Key: HIVE-14812 URL: https://issues.apache.org/jira/browse/HIVE-14812 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14813) Make TransactionBatchImpl.toString() include state of each txn: commit/abort

2016-09-21 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-14813: - Summary: Make TransactionBatchImpl.toString() include state of each txn: commit/abort Key: HIVE-14813 URL: https://issues.apache.org/jira/browse/HIVE-14813 Project:

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-21 Thread Illya Yalovyy
> On Sept. 17, 2016, 1:36 a.m., Chaoyu Tang wrote: > > service/src/java/org/apache/hive/service/auth/ldap/Query.java, line 122 > > > > > > Will it improve the performance to set the search limit? I did not see > > i

Re: Review Request 51694: HIVE-14713 LDAP Authentication Provider should be covered with unit tests

2016-09-21 Thread Illya Yalovyy
> On Sept. 21, 2016, 12:50 a.m., Szehon Ho wrote: > > This looks like a great refactoring to me. This class was always hard to > > understand, and this makes it a little easier. I'll defer to Chaoyu to the > > comments. Thank you! - Illya --

[jira] [Created] (HIVE-14814) metastoreClient is used directly in Hive cause NPE

2016-09-21 Thread Prasanth Jayachandran (JIRA)
Prasanth Jayachandran created HIVE-14814: Summary: metastoreClient is used directly in Hive cause NPE Key: HIVE-14814 URL: https://issues.apache.org/jira/browse/HIVE-14814 Project: Hive

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 22, 2016, 1:08 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Ke Jia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/ --- (Updated Sept. 22, 2016, 1:53 a.m.) Review request for hive and cheng xu. Rep

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review149940 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Rui Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/ --- (Updated Sept. 22, 2016, 4:05 a.m.) Review request for hive. Bugs: HIVE-14412

Re: Review Request 50787: Add a timezone-aware timestamp

2016-09-21 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50787/#review149942 --- Ship it! Ship It! - Xuefu Zhang On Sept. 22, 2016, 4:05 a.m.

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-21 Thread Jianguo Tian
> On Sept. 13, 2016, 2:52 a.m., Vihang Karajgaonkar wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 211 > > > > > > Will it work when we redirect the beeline output to a file? > > Jianguo Tia

[GitHub] hive pull request #103: HIVE-14029: Update Spark version to 2.0.0

2016-09-21 Thread winningsix
GitHub user winningsix opened a pull request: https://github.com/apache/hive/pull/103 HIVE-14029: Update Spark version to 2.0.0 Changes include: * Spark API updates: 1. SparkShuffler#call return Iterator instead of Iterable 2. SparkListener -> JavaSparkListener 3

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-21 Thread Jianguo Tian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51695/ --- (Updated Sept. 22, 2016, 6:48 a.m.) Review request for hive and cheng xu. Bug

Re: Review Request 51695: HIVE-5867: JDBC driver and beeline should support executing an initial SQL script

2016-09-21 Thread Jianguo Tian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51695/ --- (Updated Sept. 22, 2016, 6:49 a.m.) Review request for hive and cheng xu. Bug