Re: unit tests in patches

2015-10-02 Thread Szehon Ho
n being used to represent > branches > > a jira does go into. > > > > On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan > > > wrote: > > > >> Hi everyone, > >> > >> Generally, its a good idea to add unit tests in patches especially whe

Re: unit tests in patches

2015-09-22 Thread Sushanth Sowmyan
Version being used to represent branches > a jira does go into. > > On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan > wrote: > >> Hi everyone, >> >> Generally, its a good idea to add unit tests in patches especially when its >> easy to repro (e.g,., NPE). This m

Re: unit tests in patches

2015-09-22 Thread Siddharth Seth
Can a 'Target Version' field be added to jiras ? That would help to get rid of the confusion caused by Fix Version being used to represent branches a jira does go into. On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan wrote: > Hi everyone, > > Generally, its a good idea t

Re: unit tests in patches

2015-09-21 Thread Szehon Ho
panel#comment-14791395 >>> >>> >>> On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan >>> wrote: >>> > Hi everyone, >>> > >>> > Generally, its a good idea to add unit tests in patches especially >>> when its >>> > eas

Re: unit tests in patches

2015-09-21 Thread Szehon Ho
.org/jira/browse/HDFS-9091?focusedCommentId=14791395&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14791395 >> >> >> On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan >> wrote: >> > Hi everyone, >> > >> > Generally, its a good idea to a

Re: unit tests in patches

2015-09-21 Thread Szehon Ho
ssues.apache.org/jira/browse/HDFS-9091?focusedCommentId=14791395&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14791395 > > > On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan > wrote: > > Hi everyone, > > > > Generally, its a good

Re: unit tests in patches

2015-09-21 Thread Thejas Nair
page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14791395 On Mon, Sep 21, 2015 at 12:55 PM, Ashutosh Chauhan wrote: > Hi everyone, > > Generally, its a good idea to add unit tests in patches especially when its > easy to repro (e.g,., NPE). This may not always be possible, but we should &g

unit tests in patches

2015-09-21 Thread Ashutosh Chauhan
Hi everyone, Generally, its a good idea to add unit tests in patches especially when its easy to repro (e.g,., NPE). This may not always be possible, but we should aim to add tests wherever we can. In addition to regression testing, tests also proves the existence of bug. I would especially like