Re: did you always have to log in to phabricator

2013-10-01 Thread Edward Capriolo
Previously we all agreed that the poster of the patch could chose the review board of their choice. When this was agreed upon review board did not require a login to view a review. I will likely start a PMC vote on this issue soon. If the vote passes we will remove mention of phabricator from the

Re: did you always have to log in to phabricator

2013-10-01 Thread Sean Busbey
Well, the ASF review board does currently work. Our dev guide suggests that either it or fabricator are fine. Generally all of my own jira submissions include a RB, so I'm fairly confident it works (for the features that RB has generally). I presume something as strong as a statement of "we're goi

Re: did you always have to log in to phabricator

2013-10-01 Thread Edward Capriolo
I do not know what to say on this, other then we are stuck between a rock and a hard place. I would say we should just stop using fabricator all together, but then again we already have two tickets opened with ASF-infrastructure not going anywhere for months (moving our site to a CMS, fixing the br

Re: did you always have to log in to phabricator

2013-09-28 Thread Sean Busbey
Bump. Any update on this? On Tue, Sep 17, 2013 at 12:41 PM, Edward Capriolo wrote: > I do not like this. It is inconvenience when using a mobile device, but > more importantly it does not seem very transparent to our end users. For > example, a user is browsing jira they may want to review the c

Re: did you always have to log in to phabricator

2013-09-17 Thread Edward Capriolo
I do not like this. It is inconvenience when using a mobile device, but more importantly it does not seem very transparent to our end users. For example, a user is browsing jira they may want to review the code only on review board (not yet attached to the issue), they should not be forced to "sign

Re: did you always have to log in to phabricator

2013-09-17 Thread Xuefu Zhang
Yeah. I used to be able to view w/o login, but now I am not. On Tue, Sep 17, 2013 at 7:27 AM, Brock Noland wrote: > Personally I prefer Review Board. > > On Tue, Sep 17, 2013 at 8:31 AM, Edward Capriolo > wrote: > > I never remeber having to log into phabricator to view a patch. Has this > > c

Re: did you always have to log in to phabricator

2013-09-17 Thread Brock Noland
Personally I prefer Review Board. On Tue, Sep 17, 2013 at 8:31 AM, Edward Capriolo wrote: > I never remeber having to log into phabricator to view a patch. Has this > changed recently? I believe that having to create an external account to > view a patch in progress is not something we should be

did you always have to log in to phabricator

2013-09-17 Thread Edward Capriolo
I never remeber having to log into phabricator to view a patch. Has this changed recently? I believe that having to create an external account to view a patch in progress is not something we should be doing.