Hey All!
After jumping over some further requirements/etc I was able to make this work
and merge it!
It already found some PRs which are changing the parser/thrift api - which I
would have missed otherwise.
I hope that this could help us increasing our PR review rate. I would like to
suggest t
Hey All!
I've prepared the things need for this a long time ago - I've only opened the
PR now...
If you would like to extend the assign-by-files - please either leave a comment on the PR
; or use the "Edit file" option on github to add your changes!
https://github.com/apache/hive/pull/1767/fi
Hey Jagat!
Thank you for your feedback - we should definetly need to improve on these
fronts.
I'll get to that when I could - but I'll also answer your questions here as
well.
On 6/19/20 3:16 AM, Jagat Singh wrote:
One thing which needs improvement is updating of Hive Contributors wiki
with
Hello Zoltan,
One thing which needs improvement is updating of Hive Contributors wiki
with whatever process happens on Github and Build server-side.
The current confluence is silent on what to expect when we create a PR as a
contributor, who will review, what will build system do? Where to look f
Hey Panos!
On 6/18/20 11:54 AM, Panos Garefalakis wrote:
My only suggestion would be to make reviewing per package/label instead of
files. This will make the process a bit more clear.
we could use path globs to select the files - so it could match on packages as
well
I've not really used it
'
Hey Zoltan,
Thanks for doing this! This is definitely a step towards the right
direction.
My only suggestion would be to make reviewing per package/label instead of
files. This will make the process a bit more clear.
I recently bumped into this GitHub action that lets you automatically label
PRs
Hey all!
I'm happy to see that (I guess) everyone is using the PR based stuff without issues - there are still some flaky stuff from time-to-time; but I feel that patches go in
faster - and I have a feeling we have more reviewes going on as well - which is awesome!
I've read a bit about github
