Re: Review Request 71811: Extract Compiler from Driver

2019-11-30 Thread Miklos Gergely
> On Nov. 28, 2019, 12:39 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Compiler.java > > Lines 165 (patched) > > > > > > I think DriverState should live at the "Driver" level; and not get

Re: Review Request 71811: Extract Compiler from Driver

2019-11-30 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/ --- (Updated Dec. 1, 2019, 7:12 a.m.) Review request for hive and Zoltan Haindrich.

Re: Review Request 71811: Extract Compiler from Driver

2019-11-30 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/ --- (Updated Nov. 30, 2019, 10:54 a.m.) Review request for hive and Zoltan Haindric

Re: Review Request 71811: Extract Compiler from Driver

2019-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/ --- (Updated Nov. 29, 2019, 9:47 p.m.) Review request for hive and Zoltan Haindrich

Re: Review Request 71811: Extract Compiler from Driver

2019-11-29 Thread Miklos Gergely
> On Nov. 28, 2019, 12:39 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Compiler.java > > Lines 167 (patched) > > > > > > I don't feel this closely connected to compilation; queryId could be

Re: Review Request 71811: Extract Compiler from Driver

2019-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/#review218856 --- ql/src/java/org/apache/hadoop/hive/ql/Compiler.java Lines 101 (pa

Re: Review Request 71811: Extract Compiler from Driver

2019-11-28 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/#review218846 --- ql/src/java/org/apache/hadoop/hive/ql/Compiler.java Lines 101 (pa

Review Request 71811: Extract Compiler from Driver

2019-11-25 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71811/ --- Review request for hive and Zoltan Haindrich. Bugs: HIVE-22526 https://issu