Re: Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/#review219672 --- Ship it! +1 LGTM - Krisztian Kasa On Feb. 27, 2020, 12:57 p.

Re: Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-27 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/ --- (Updated Feb. 27, 2020, 12:57 p.m.) Review request for hive, Gopal V, Jesús Cam

Re: Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-26 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/#review219667 --- Overall LGTM, left mostly minor comments. - Jesús Camacho Rodrígu

Re: Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-26 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/#review219661 --- ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyFilter.java Lin

Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-25 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/ --- Review request for hive, Gopal V, Jesús Camacho Rodríguez, Krisztian Kasa, and P