Re: Review Request 71589: Create read-only transactions

2019-10-31 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 31, 2019, 3:21 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-31 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 31, 2019, 3:20 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-30 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 30, 2019, 12:23 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

2019-10-28 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 28, 2019, 1:40 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-22 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 22, 2019, 1:24 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-17 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 17, 2019, 12:37 p.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 71589: Create read-only transactions

2019-10-17 Thread Peter Vary via Review Board
> On okt. 17, 2019, 11:10 de, Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 992 (original), 1003 (patched) > > > > > > Why is this a List of Pairs, why not just a Map? Is the order

Re: Review Request 71589: Create read-only transactions

2019-10-17 Thread Denys Kuzmenko via Review Board
> On Oct. 17, 2019, 11:10 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 992 (original), 1003 (patched) > > > > > > Why is this a List of Pairs, why not just a Map? Is the ord

Re: Review Request 71589: Create read-only transactions

2019-10-17 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218258 --- nits and a single question ql/src/java/org/apache/hadoop/hive/ql

Re: Review Request 71589: Create read-only transactions

2019-10-17 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 17, 2019, 8:41 a.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-14 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218201 --- ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java L

Re: Review Request 71589: Create read-only transactions

2019-10-14 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218200 --- +1 pending tests. And some nits, just to be constructive :D :D :D

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 10, 2019, 4:09 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- (Updated Oct. 10, 2019, 4:09 p.m.) Review request for hive, Laszlo Pinter and P

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Denys Kuzmenko via Review Board
> On Oct. 10, 2019, 7:46 a.m., Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still mig

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Peter Vary via Review Board
> On okt. 10, 2019, 7:46 de, Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still might

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Denys Kuzmenko via Review Board
> On Oct. 10, 2019, 7:46 a.m., Peter Vary wrote: > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseUtils.java > > Lines 47 (patched) > > > > > > What about CREATE TABLE AS SELECT * FROM...? > > We still mig

Re: Review Request 71589: Create read-only transactions

2019-10-10 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/#review218174 --- One more question to find a way to identify write queries. Otherwi

Review Request 71589: Create read-only transactions

2019-10-08 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71589/ --- Review request for hive, Laszlo Pinter and Peter Vary. Bugs: HIVE-21114 htt