Re: Review Request 61985: HIVE-17399

2017-08-31 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61985/ --- (Updated Aug. 31, 2017, 7:26 a.m.) Review request for hive, Gopal V and Jason D

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
> On Aug. 30, 2017, 3:35 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.java > > Lines 30 (patched) > > > > > > I prefer a Boolean object, which goes from null -> false/true, s

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61985/ --- (Updated Aug. 30, 2017, 5:58 a.m.) Review request for hive, Gopal V and Jason D

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
> On Aug. 30, 2017, 3:35 a.m., Gopal V wrote: > > Thanks for quick turnaround. Working on the comments. > On Aug. 30, 2017, 3:35 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.java > > Lines 30 (patched) > >

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61985/#review184120 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemiJoinBranchInfo.ja

Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61985/ --- Review request for hive, Gopal V and Jason Dere. Bugs: HIVE-17399 https://i