Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-14 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53593/#review155870 --- Ship it! Ship It! - Prasanth_J On Nov. 14, 2016, 8:45 p.m.,

Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53593/ --- (Updated Nov. 14, 2016, 8:45 p.m.) Review request for hive and Prasanth_J. Re

Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-14 Thread Sergey Shelukhin
> On Nov. 11, 2016, 12:28 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java, > > line 329 > > > > > > nit: Can the batchkey be null? no - Sergey

Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-10 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53593/#review155661 --- llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/Llap

Re: Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-09 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53593/#review155539 --- llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEn

Review Request 53593: HIVE-14089 complex type support in LLAP IO is broken

2016-11-08 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53593/ --- Review request for hive and Prasanth_J. Repository: hive-git Description