Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-28 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review150736 --- Ship it! Ship It! - Szehon Ho On Sept. 28, 2016, 2:12 p.m.,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-28 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- (Updated Sept. 28, 2016, 2:12 p.m.) Review request for hive, Gabor Szadovszky,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-27 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review150591 --- Looks mostly great, thanks for doing this. Also agree with Mohit

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-27 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review150575 --- common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetri

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149832 --- Ship it! Thanks, LGTM. - Gabor Szadovszky On Sept. 21, 2016,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149828 --- LGTM, thanks for the patch - Peter Vary On Sept. 21, 2016, 3:20

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- (Updated Sept. 21, 2016, 3:20 p.m.) Review request for hive, Gabor Szadovszky,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
> On Sept. 21, 2016, 12:16 p.m., Gabor Szadovszky wrote: > > Thanks for the patch. > > One minor finding and a question: > > At many places you have refactored to throw unchecked exceptions instead of > > checked ones while removed the catch blocks of the checked ones. Are you > > sure it canno

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- (Updated Sept. 21, 2016, 3:19 p.m.) Review request for hive, Gabor Szadovszky,

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149805 --- Thanks Zsombor! Godd refactor, just minor nits, and some question

Re: Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/#review149810 --- Thanks for the patch. One minor finding and a question: At many pl

Review Request 52084: HIVE-14775: Investigate IOException usage in Metrics APIs

2016-09-21 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52084/ --- Review request for hive, Gabor Szadovszky, Peter Vary, Sergio Pena, and Szehon H