Re: Review Request 51755: Support Intersect Except

2016-10-21 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 22, 2016, 2:55 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 51755: Support Intersect Except

2016-10-21 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 22, 2016, 12:31 a.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 51755: Support Intersect Except

2016-10-21 Thread pengcheng xiong
> On Oct. 21, 2016, 2:23 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectOverIntersectRemoveRule.java, > > line 52 > > > > > > I presume you want if() here i

Re: Review Request 51755: Support Intersect Except

2016-10-21 Thread pengcheng xiong
> On Oct. 21, 2016, 2:23 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java, > > line 42 > > > > > > It seems this rule is not called from anyw

Re: Review Request 51755: Support Intersect Except

2016-10-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/#review153543 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalci

Re: Review Request 51755: Support Intersect Except

2016-10-20 Thread pengcheng xiong
> On Oct. 18, 2016, 11:09 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java, > > line 956 > > > > > > Does this need to be public? Yes, it is used by two

Re: Review Request 51755: Support Intersect Except

2016-10-20 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 20, 2016, 6:12 p.m.) Review request for hive and Ashutosh Chauhan