Re: Review Request 48502: HIVE-13731 LLAP: return LLAP token with the splits

2016-06-10 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48502/ --- (Updated June 10, 2016, 7:19 p.m.) Review request for hive, Jason Dere and Sidd

Re: Review Request 48502: HIVE-13731 LLAP: return LLAP token with the splits

2016-06-10 Thread Sergey Shelukhin
> On June 10, 2016, 1:11 a.m., Jason Dere wrote: > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java, > > line 135 > > > > > > Looks like a null tokenBytes is serialized/deserialized as

Re: Review Request 48502: HIVE-13731 LLAP: return LLAP token with the splits

2016-06-10 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48502/#review137053 --- The token is the same for all splits. At some point we need to sto

Re: Review Request 48502: HIVE-13731 LLAP: return LLAP token with the splits

2016-06-09 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48502/#review136949 --- itests/hive-unit/src/test/java/org/apache/hadoop/hive/llap/ext/Te

Review Request 48502: HIVE-13731 LLAP: return LLAP token with the splits

2016-06-09 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48502/ --- Review request for hive, Jason Dere and Siddharth Seth. Repository: hive-git