Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated May 22, 2016, 7:10 p.m.) Review request for hive and Ashutosh Chauhan.

Re: Review Request 46690: HIVE-13068

> On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog_semijoin.q.out, lines 440-443 > > > > > > Simplification of this expression is false, no? > > Jesús Camacho Rodr

Re: Review Request 46690: HIVE-13068

> On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog_semijoin.q.out, line 692 > > > > > > Follow-up? > > Jesús Camacho Rodríguez wrote: > Yes, I will need to che

Re: Review Request 46690: HIVE-13068

> On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/cbo_rp_join1.q.out, line 144 > > > > > > No need for additional filter. Follow-up? > > Jesús Camacho Rodríguez wrote: >

Re: Review Request 46690: HIVE-13068

> On May 21, 2016, 4:41 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java, > > line 113 > > > > > > This is weird. Why does backtrack() needs to worry abou

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/#review134227 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/FixedBucketPrunin

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated May 20, 2016, 9:53 p.m.) Review request for hive and Ashutosh Chauhan.

Re: Review Request 46690: HIVE-13068

> On May 18, 2016, 8:56 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/dynamic_rdd_cache.q.out, line 1070 > > > > > > Here we lost propgation. Already covered with one of the follow-ups? We di

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/#review133793 --- Took another pass on golden file updates. Some of the changes may

Re: Review Request 46690: HIVE-13068

> On May 16, 2016, 4:30 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog3.q.out, line 56 > > > > > > Is this change correct? > > Jesús Camacho Rodríguez wrote: > This change is corre

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated May 18, 2016, 2:06 p.m.) Review request for hive and Ashutosh Chauhan.

Re: Review Request 46690: HIVE-13068

> On May 16, 2016, 4:30 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/constprog3.q.out, line 56 > > > > > > Is this change correct? This change is correct; observe that the other join input has

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/#review133370 --- hbase-handler/src/test/results/positive/hbase_ppd_key_range.q.out

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated May 14, 2016, 11:47 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated May 14, 2016, 10:53 a.m.) Review request for hive and Ashutosh Chauhan

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated April 28, 2016, 9:06 a.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- (Updated April 27, 2016, 4:26 p.m.) Review request for hive and Ashutosh Chauha

Review Request 46690: HIVE-13068

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46690/ --- Review request for hive. Bugs: HIVE-13068 https://issues.apache.org/jira/br