Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review116943 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 29, 2016

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 29, 2016, 12:54 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 29, 2016, 12:53 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

> On Jan. 29, 2016, 12:44 p.m., Amareshwari Sriramadasu wrote: > > service/src/java/org/apache/hive/service/cli/session/SessionManager.java, > > line 283 > > > > > > Can we make it package private? No, if this is

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review116920 --- service/src/java/org/apache/hive/service/cli/CLIService.java (lin

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 28, 2016, 12:48 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 27, 2016, 8:55 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

> On Jan. 27, 2016, 5:50 p.m., Amareshwari Sriramadasu wrote: > > service/src/java/org/apache/hive/service/cli/CLIService.java, line 207 > > > > > > Shall we remove the return from the method, which is not adding an

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review116580 --- service/src/java/org/apache/hive/service/cli/CLIService.java (lin

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 21, 2016, 7:09 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 18, 2016, 4:07 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 18, 2016, 3:13 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 18, 2016, 2:55 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 14, 2016, 12:29 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 13, 2016, 4:57 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 12, 2016, 3:25 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 11, 2016, 5:24 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113730 --- service/src/test/org/apache/hive/service/cli/CLIServiceTest.java (

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 11, 2016, 3:52 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 11, 2016, 1:12 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

> On Jan. 7, 2016, 10:17 a.m., Amareshwari Sriramadasu wrote: > > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java, line 91 > > > > > > Restoring a closed session? I dont think this should be allowed.

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 8, 2016, 12:22 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113180 --- service/src/java/org/apache/hive/service/cli/session/SessionManage

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 6, 2016, 12:29 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 6, 2016, 12:26 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 6, 2016, 12:21 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113021 --- Can you include code only with thrift changes and no generated code

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 6, 2016, 12:09 p.m.) Review request for hive. Bugs: HIVE-12777

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/#review113017 --- service/src/java/org/apache/hive/service/cli/CLIService.java (line

Re: Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- (Updated Jan. 5, 2016, 8:42 p.m.) Review request for hive. Bugs: HIVE-12777

Review Request 41928: HIVE-12777: Add capability to restore session

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41928/ --- Review request for hive. Bugs: HIVE-12777 https://issues.apache.org/jira/br