Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 21, 2015, 5:11 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hive/http/JMXJsonServlet.java, line 252 > > > > > > "exceptionscan" -> "exception scan" Thanks for fixing it the way I meant ... ex

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107938 --- Ship it! Ship It! - Lefty Leverenz On Nov. 24, 2015, 7:36 p.m.,

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/ --- (Updated Nov. 24, 2015, 7:36 p.m.) Review request for hive, Szehon Ho and Xuefu

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/ --- (Updated Nov. 23, 2015, 9:51 p.m.) Review request for hive, Szehon Ho and Xuefu

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 23, 2015, 9:37 p.m., Szehon Ho wrote: > > service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp, line 168 > > > > > > One more comment, no need to put 'version', just 'When Hive version was > > co

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107271 --- common/pom.xml (line 61)

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 21, 2015, 5:11 a.m., Lefty Leverenz wrote: > > Good catches. Thanks a lot for the review. - Jimmy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107474 ---

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107474 --- common/src/java/org/apache/hive/http/HttpServer.java (line 114)

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote: > > LGTM. This patch only includes SQLOperations. Are we planning to add > > metadata operations as well ? (so we can capture jdbc clients and Hue usage > > as well...) > > Jimmy Xiang wrote: > Thanks a lot for the review. I was thinkin

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote: > > LGTM. This patch only includes SQLOperations. Are we planning to add > > metadata operations as well ? (so we can capture jdbc clients and Hue usage > > as well...) > > Jimmy Xiang wrote: > Thanks a lot for the review. I was thinkin

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote: > > LGTM. This patch only includes SQLOperations. Are we planning to add > > metadata operations as well ? (so we can capture jdbc clients and Hue usage > > as well...) Thanks a lot for the review. I was thinking about showing meta operatio

Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/#review107283 --- LGTM. This patch only includes SQLOperations. Are we planning to ad

Review Request 40500: HIVE-12338 Add webui to HiveServer2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40500/ --- Review request for hive, Szehon Ho and Xuefu Zhang. Bugs: HIVE-12338 https: