Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/#review89659 --- Ship it! Ship It! - Xuefu Zhang On June 27, 2015, 8:17 p.m., Ale

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
> On June 28, 2015, 3:30 a.m., Xuefu Zhang wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 394 > > > > > > This is nice, but will break java 6 build. Though, I'm not sure if jdk6 > > support is

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/#review89652 --- jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 394) <

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/ --- (Updated June 27, 2015, 8:17 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Alexander Pivovarov
> On June 27, 2015, 1:56 p.m., Xuefu Zhang wrote: > > Ship It! Thank you Xuefu! Could you leave +1 in the Jira comments - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/#revi

Re: Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-27 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/#review89624 --- Ship it! Ship It! - Xuefu Zhang On June 27, 2015, 3:23 a.m., Ale

Review Request 35963: HIVE-7150 FileInputStream is not closed in HiveConnection class

2015-06-26 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35963/ --- Review request for hive, Ashutosh Chauhan and Thejas Nair. Bugs: HIVE-7150