Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/#review89686 --- Ship it! Ship It! - Xuefu Zhang On June 26, 2015, 8:02 a.m., che

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- (Updated June 26, 2015, 4:02 p.m.) Review request for hive, chinna and Xuefu Zh

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- (Updated June 26, 2015, 2 p.m.) Review request for hive, chinna and Xuefu Zhang

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 25, 2015, 6:21 a.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/Commands.java, line 820 > > > > > > Does this mean that env and sys variables are not being substituted for > > shell comm

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 26, 2015, 5:54 a.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/Commands.java, line 855 > > > > > > This used to call BeeLine.executeFile() now you have a new > > implementation. I don't

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 24, 2015, 10:21 p.m., Xuefu Zhang wrote: > > beeline/src/java/org/apache/hive/beeline/Commands.java, line 820 > > > > > > Does this mean that env and sys variables are not being substituted for > > shell com

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/#review89421 --- beeline/src/java/org/apache/hive/beeline/Commands.java (line 721) <

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- (Updated June 25, 2015, 1:54 p.m.) Review request for hive, chinna and Xuefu Zh

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 25, 2015, 6:21 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java, line 146 > > > > > > Could we keep @Override at a separate line? Same for other places. I am us

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/#review89251 --- beeline/src/java/org/apache/hive/beeline/Commands.java (line 717) <

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- (Updated June 24, 2015, 3:39 p.m.) Review request for hive, chinna and Xuefu Zh

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 8, 2015, 9:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beeli

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 4:41 a.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beeli

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 4:41 a.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beeli

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 4:41 a.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beeli

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

> On June 9, 2015, 12:41 p.m., Xuefu Zhang wrote: > > Besides the two minor issues I found in the patch, I was wondering if the > > approach we are taking is the best. Variable substitution is a server (HS2) > > behavior, and on this ground I think this should happen in HS2 instead of > > beel

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/#review87090 --- Besides the two minor issues I found in the patch, I was wondering i

Re: Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- (Updated June 5, 2015, 10:09 a.m.) Review request for hive, chinna and Xuefu Zh

Review Request 35107: HIVE-6791 Support variable substition for Beeline shell command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35107/ --- Review request for hive, chinna and Xuefu Zhang. Bugs: HIVE-6791 https://is