Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-29 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34696/#review85812 --- Ship it! Looks good. Code is simple to read. - Sergio Pena On Ma

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-27 Thread Swarnim Kulkarni
> On May 27, 2015, 4:42 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSubstringIndex.java, > > line 45 > > > > > > Worth mentinoning in your example what the expected out

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-27 Thread Alexander Pivovarov
> On May 27, 2015, 4:42 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSubstringIndex.java, > > line 45 > > > > > > Worth mentinoning in your example what the expected out

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-27 Thread Swarnim Kulkarni
> On May 27, 2015, 4:42 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSubstringIndex.java, > > line 45 > > > > > > Worth mentinoning in your example what the expected out

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Alexander Pivovarov
> On May 27, 2015, 4:42 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSubstringIndex.java, > > line 45 > > > > > > Worth mentinoning in your example what the expected out

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34696/#review85318 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSubstri

Re: Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34696/#review85319 --- Ship it! Ship It! - Swarnim Kulkarni On May 27, 2015, 3:35 a.m.,

Review Request 34696: HIVE-686 add UDF substring_index

2015-05-26 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34696/ --- Review request for hive, Hao Cheng, Jason Dere, namit jain, and Thejas Nair. Bu