Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/#review86220 --- Ship it! Ship It! - Sergio Pena On June 1, 2015, 7:20 p.m., Alex

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/ --- (Updated June 1, 2015, 7:20 p.m.) Review request for hive, Ashutosh Chauhan and

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/#review85989 --- Ship it! Looks good. The StringBuilder is not being used in places

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

> On May 21, 2015, 5:06 a.m., Swarnim Kulkarni wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java, line > > 1833 > > > > > > Out of curiosity, any specific reason for this change? I chang

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/#review84659 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java

Re: Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/#review84657 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java

Review Request 34522: HIVE-10748 Replace StringBuffer with StringBuilder where possible

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34522/ --- Review request for hive. Bugs: HIVE-10748 https://issues.apache.org/jira/br