Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review81741 --- Ship it! Ship It! - Jimmy Xiang On April 27, 2015, 9:13 p.m., Ch

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 27, 2015, 8:22 p.m., Jimmy Xiang wrote: > > You removed partition_coltype_literals.q and > > partition_coltype_literals.q.out? That was an accident. I just realized and they have been added back to most recent patch. - Chaoyu -

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 27, 2015, 9:13 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review81727 --- You removed partition_coltype_literals.q and partition_coltype_liter

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 27, 2015, 6:34 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 27, 2015, 4:58 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 17, 2015, 12:28 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 1951-1954 > > > > > > typo: "covert" should be "convert" in line 1953 Looks good in new pat

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review80737 --- Thanks for the explanation. The patch looks good to me. - Jimmy Xia

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 17, 2015, 8:30 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 16, 2015, 6:51 p.m., Jimmy Xiang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java, line > > 1235 > > > > > > Why do we need this checking? Does this mean we can't use the de

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review80511 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 16, 2015, 6:51 p.m., Jimmy Xiang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java, line > > 1235 > > > > > > Why do we need this checking? Does this mean we can't use the de

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 16, 2015, 6:51 p.m., Jimmy Xiang wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1948 > > > > > > What will happen if user uses the old parameter? > > Chaoyu Tang wrote: > I

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

> On April 16, 2015, 6:51 p.m., Jimmy Xiang wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1948 > > > > > > What will happen if user uses the old parameter? I thought it might be better to

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 16, 2015, 9:38 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 16, 2015, 9:25 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/#review80275 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- (Updated April 15, 2015, 2:44 p.m.) Review request for hive, Ashutosh Chauhan,

Review Request 33171: HIVE-10307:Support to use number literals in partition column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33171/ --- Review request for hive, Ashutosh Chauhan, Szehon Ho, and Xuefu Zhang. Summary