Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-04-03 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/#review78882 --- Ship it! Ship It! - Thejas Nair On April 1, 2015, 9:07 p.m., Jas

Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-04-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/ --- (Updated April 1, 2015, 9:07 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-04-01 Thread Jason Dere
> On April 1, 2015, 1:34 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java, line 167 > > > > > > can we re-use typeStringToHiveType here ? > > I see void and null as only things that n

Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-03-31 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/#review78462 --- jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java

Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-03-20 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/ --- (Updated March 20, 2015, 11:48 p.m.) Review request for hive, Ashutosh Chauhan

Review Request 32324: HIVE-10037 JDBC support for interval expressions

2015-03-20 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/ --- Review request for hive, Ashutosh Chauhan and Thejas Nair. Bugs: HIVE-10037