Re: Review Request 30254: HIVE-9444

2015-02-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70991 --- Ship it! Ship It! - John Pullokkaran On Feb. 4, 2015, 9:36 a.m.,

Re: Review Request 30254: HIVE-9444

2015-02-04 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- (Updated Feb. 4, 2015, 9:36 a.m.) Review request for hive and John Pullokkaran.

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70854 --- ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread John Pullokkaran
> On Feb. 3, 2015, 8:20 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 155 > > > > > > How are we handling subclassess. i.e caller specified both parent class > >

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
> On Feb. 3, 2015, 8:20 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 155 > > > > > > How are we handling subclassess. i.e caller specified both parent class > >

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
> On Feb. 3, 2015, 8:25 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 175 > > > > > > What happens when you have more than one operator for the given class? > >

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70820 --- ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70819 --- ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- (Updated Feb. 3, 2015, 7:51 p.m.) Review request for hive and John Pullokkaran.

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70773 --- ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- (Updated Feb. 3, 2015, 10:52 a.m.) Review request for hive and John Pullokkaran

Re: Review Request 30254: HIVE-9444

2015-02-03 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- (Updated Feb. 3, 2015, 10:46 a.m.) Review request for hive and John Pullokkaran

Re: Review Request 30254: HIVE-9444

2015-02-02 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- (Updated Feb. 2, 2015, 7:03 p.m.) Review request for hive and John Pullokkaran.

Re: Review Request 30254: HIVE-9444

2015-01-29 Thread Jesús Camacho Rodríguez
> On Jan. 28, 2015, 10:45 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java, > > line 155 > > > > > > How are carrying forward the assumptions? > > Cluste

Re: Review Request 30254: HIVE-9444

2015-01-28 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70102 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimize

Review Request 30254: HIVE-9444

2015-01-25 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/ --- Review request for hive and John Pullokkaran. Bugs: HIVE-9444 https://issue