Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- (Updated Nov. 18, 2014, 1:52 a.m.) Review request for hive, Rui Li, Szehon Ho,

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- (Updated Nov. 18, 2014, 1:37 a.m.) Review request for hive, Rui Li, Szehon Ho,

Re: Review Request 27987: HIVE-8833 implement remote spark client

> On Nov. 17, 2014, 10:11 p.m., Szehon Ho wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java, > > line 193 > > > > > > Sorry for the basic question, what is 'spark' as spark.master

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/#review61819 --- Looks mostly good, just some minor nits and basic question as I'm no

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- (Updated Nov. 17, 2014, 3:47 a.m.) Review request for hive, Rui Li, Szehon Ho,

Re: Review Request 27987: HIVE-8833 implement remote spark client

> On Nov. 14, 2014, 7:32 p.m., Marcelo Vanzin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClient.java, line > > 26 > > > > > > nit: space before { > > > > Maybe implement Closeable? f

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/#review61479 --- Ship it! LGTM, just small nits. ql/src/java/org/apache/hadoop/hiv

Re: Review Request 27987: HIVE-8833 implement remote spark client

> On 十一月 14, 2014, 4:39 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java, > > line 73 > > > > > > Public or private? Package scope should be suitable here, as we

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/#review61398 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkCli

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- (Updated Nov. 14, 2014, 3:43 a.m.) Review request for hive, Rui Li, Szehon Ho,

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- (Updated Nov. 14, 2014, 3:34 a.m.) Review request for hive, Rui Li, Szehon Ho,

Re: Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/#review61250 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReduc

Review Request 27987: HIVE-8833 implement remote spark client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27987/ --- Review request for hive, Rui Li, Szehon Ho, and Xuefu Zhang. Bugs: HIVE-8833