Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-15 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/#review56698 --- Ship it! Ship It! - Xuefu Zhang On Oct. 15, 2014, 12:55 p.m., Ji

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-15 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/ --- (Updated Oct. 15, 2014, 12:55 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-13 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/#review56487 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-13 Thread Jimmy Xiang
> On Oct. 13, 2014, 10:26 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java, > > line 49 > > > > > > Nit: could we put -1L or skip it and suppress the warning

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-13 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/#review56449 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionRe

Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

2014-10-13 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-7873 https://issues.apa