Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-15 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56793 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRel

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-15 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56777 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/stats/HiveRel

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-11 Thread Mohit Sabharwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56307 --- Thanks for the cleanup! Just couple of nits... ql/src/java/org/apa

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-11 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56285 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-11 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/ --- (Updated Oct. 11, 2014, 8:11 a.m.) Review request for hive. Bugs: HIVE-8222

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-11 Thread Lars Francke
> On Oct. 11, 2014, 12:42 a.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/RelOptHiveTable.java, > > line 210 > > > > > > Why this move? This was one of the instances where the

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-11 Thread Lars Francke
> On Oct. 11, 2014, 12:45 a.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java, line 406 > > > > > > Please don't remove type casts in the code. > > If you wanto addre

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-10 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56267 --- ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java <

Re: Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-10 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/#review56249 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/HiveTypeSyste

Review Request 26577: HIVE-8222: Cleanup CBO code

2014-10-10 Thread Lars Francke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26577/ --- Review request for hive. Bugs: HIVE-8222 https://issues.apache.org/jira/bro