Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-16 Thread Thejas Nair
> On Sept. 16, 2014, 6:42 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 741 > > > > > > should we skip it from ReadEntity if none of the columns are being used > > ? Though, that

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-16 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/#review53593 --- Ship it! Ship It! - Thejas Nair On Sept. 16, 2014, 7:37 p.m., Al

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-16 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/#review53580 --- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/a

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-16 Thread Alan Gates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/ --- (Updated Sept. 16, 2014, 7:37 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-16 Thread Alan Gates
> On Sept. 16, 2014, 6:42 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 741 > > > > > > should we skip it from ReadEntity if none of the columns are being used > > ? Though, that

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-15 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/#review53485 --- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/a

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-15 Thread Alan Gates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/ --- (Updated Sept. 16, 2014, 3:35 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-15 Thread Alan Gates
> On Sept. 15, 2014, 7:24 a.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java, > > line 272 > > > > > > Wouldn't s

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-15 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/#review53316 --- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/a

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-14 Thread Alan Gates
> On Sept. 14, 2014, 7:13 a.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java, > > line 272 > > > > > > It would b

Re: Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-14 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/#review53277 --- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/a

Review Request 25616: HIVE-7790 Update privileges to check for update and delete

2014-09-13 Thread Alan Gates
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25616/ --- Review request for hive and Thejas Nair. Bugs: HIVE-7790 https://issues.apa