Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58363 --- Ship it! Ship It! - John Pullokkaran On Oct. 24, 2014, 8:35 p.m.

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Oct. 24, 2014, 8:35 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 23, 2014, 10:51 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 6440 > > > > > > Can CTAS in non cbo route handle qualified column name? > > > >

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 24, 2014, 5:10 p.m., John Pullokkaran wrote: > > ql/src/test/queries/clientpositive/ctas_colname.q, line 9 > > > > > > Why this change see HIVE-8512, the original query is not valid and should fail - Sergey

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58290 --- ql/src/test/queries/clientpositive/ctas_colname.q

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58148 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Oct. 23, 2014, 9:11 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 23, 2014, 7:47 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9960 > > > > > > Seems like we could refactor the code here for ease of maintanence: >

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 23, 2014, 7:33 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9981 > > > > > > Shouldn't this check be for msg.isEmpty as opposed to null. Since in

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58082 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58075 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58073 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58065 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review58063 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Oct. 22, 2014, 8:34 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 22, 2014, 6:48 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line > > 12427 > > > > > > This seems wrong; because of this CBO wouldn't get excersised

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 22, 2014, 2:44 a.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 372 > > > > > > Some tests reuses semanticanalyzer possibly from different threads. > >

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 22, 2014, 2:46 a.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 384 > > > > > > Why not use //? it's a javadoc - Sergey --

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

> On Oct. 22, 2014, 6:40 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line > > 12401 > > > > > > Wouldn't it be better to change this method to be verbose alwa

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57853 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57857 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57856 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57850 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57734 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57733 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Oct. 21, 2014, 1:13 a.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Oct. 7, 2014, 10:22 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Sept. 25, 2014, 2:10 a.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review54496 --- ql/src/test/queries/clientpositive/cbo_incorrectness.q

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Sept. 25, 2014, 2:06 a.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- (Updated Sept. 24, 2014, 2:43 a.m.) Review request for hive, Ashutosh Chauhan a

Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/ --- Review request for hive, Ashutosh Chauhan and John Pullokkaran. Repository: hiv