Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-18 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/#review50917 --- Ship it! Ship It! - Brock Noland On Aug. 17, 2014, 10 p.m., Venk

Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-17 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/ --- (Updated Aug. 17, 2014, 10 p.m.) Review request for hive, Brock Noland and Szeh

Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-17 Thread Venki Korukanti
> On Aug. 17, 2014, 6:10 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionManagerImpl.java, > > line 177 > > > > > > createdSessions.clear()? Added createdSessions.cl

Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-17 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/#review50843 --- This looks awesome! Thank you so much writing clean and obvious code

Re: Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-15 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/ --- (Updated Aug. 16, 2014, 2:02 a.m.) Review request for hive, Brock Noland and Sz

Review Request 24763: HIVE-7606: Design SparkSession, SparkSessionManager

2014-08-15 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24763/ --- Review request for hive, Brock Noland and Szehon Ho. Repository: hive-git Des