Re: Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24713/ --- (Updated Aug. 15, 2014, 8:28 p.m.) Review request for hive. Changes ---

Re: Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe

> On Aug. 15, 2014, 8:21 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java, line 152 > > > > > > Can we put VCols in a set for more efficiency, and also can we use > > Guava'

Re: Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24713/#review50710 --- Looks good overall to me, one minor suggestion below. ql/src/java/

Review Request 24713: HIVE-7735 : Implement Char, Varchar in ParquetSerDe

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24713/ --- Review request for hive. Bugs: HIVE-7735 https://issues.apache.org/jira/bro