Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51875 --- Ship it! Ship It! - Prasanth_J On Aug. 29, 2014, 6:13 a.m., Jaso

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/ --- (Updated Aug. 29, 2014, 6:13 a.m.) Review request for hive and Prasanth_J. Ch

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 396 > > > > > > Is there any reason why you are not using FieldSchema's equ

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: > > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, > > line 1 > > > > > > Can you also add a testcase for partitioned table? similar to > > col

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 396 > > > > > > Is there any reason why you are not using FieldSchema's equ

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: > > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, > > line 1 > > > > > > Can you also add a testcase for partitioned table? similar to > > col

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 > > > > > > This doesn't look good. Can you use Map > > instead? with key being fully qualif

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51815 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStore

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, > > line 202 > > > > > > Why not just use Warehouse.getFileStatusesForSD(tbl.getSd())? It d

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 7:59 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 89 > > > > > > This doesn't look good. Can you use Map > > instead? with key being fully qualif

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

> On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: > > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, > > line 1 > > > > > > Can you also add a testcase for partitioned table? similar to > > col

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51763 --- ql/src/test/queries/clientpositive/temp_table_display_colstats_tbll

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51762 --- ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51754 --- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.

Re: Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/ --- (Updated Aug. 26, 2014, 6:37 p.m.) Review request for hive and Prasanth_J. Bu

Review Request 24472: HIVE-7649: Support column stats with temporary tables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/ --- Review request for hive. Bugs: HIVE-7649 https://issues.apache.org/jira/bro