Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 8, 2014, 11:42 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 8, 2014, 11:36 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Gunther Hagleitner
> On Aug. 7, 2014, 12:04 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java, > > line 136 > > > > > > curlies per coding standard > > Sergey Shelukhin wrote

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-08 Thread Gunther Hagleitner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review50071 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinPr

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review4 --- HiveConf.java parameter descriptions look good. I just mentioned tw

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 7, 2014, 11:53 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 7, 2014, 11:51 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 7, 2014, 11:48 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-07 Thread Sergey Shelukhin
> On Aug. 7, 2014, 12:04 a.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java, > > line 136 > > > > > > curlies per coding standard added; next time I review

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Gunther Hagleitner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review49830 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- (Updated Aug. 6, 2014, 10 p.m.) Review request for hive, Gunther Hagleitner, Mo

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review49820 --- ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HashMapWrapp

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review49818 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinPr

Re: Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/#review49814 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinPr

Review Request 24427: HIVE-7616 pre-size mapjoin hashtable based on statistics

2014-08-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24427/ --- Review request for hive, Gunther Hagleitner, Mostafa Mokhtar, and Prasanth_J. R