Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-13 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- (Updated Aug. 13, 2014, 8:13 a.m.) Review request for hive. Bugs: HIVE-7142

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-13 Thread chengxiang li
> On Aug. 12, 2014, 11:55 p.m., Brock Noland wrote: > > serde/if/serde.thrift, line 33 > > > > > > Thank you! > > > > You also need to run the build with the thriftif profile active to > > generate the new ne

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-12 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/#review50388 --- serde/if/serde.thrift

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-11 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- (Updated Aug. 12, 2014, 2:18 a.m.) Review request for hive. Changes ---

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-11 Thread Brock Noland
> On Aug. 11, 2014, 4:52 a.m., Brock Noland wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/AbstractEncodingAwareSerDe.java, > > line 43 > > > > > > Can we make these constants? "serialization.encoding" is prob

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-11 Thread chengxiang li
> On Aug. 11, 2014, 4:52 a.m., Brock Noland wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/AbstractEncodingAwareSerDe.java, > > line 43 > > > > > > Can we make these constants? "serialization.encoding" is prob

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-11 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- (Updated Aug. 11, 2014, 7:30 a.m.) Review request for hive. Bugs: HIVE-7142

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-10 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/#review50145 --- Ultimately it'd be nice to make Hive's internal codec configurable.

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-06 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- (Updated Aug. 6, 2014, 9:11 a.m.) Review request for hive. Bugs: HIVE-7142

Re: Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-06 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- (Updated Aug. 6, 2014, 9:10 a.m.) Review request for hive. Changes --- r

Review Request 24377: HIVE-7142 Hive multi serialization encoding support

2014-08-06 Thread chengxiang li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24377/ --- Review request for hive. Bugs: HIVE-7142 https://issues.apache.org/jira/bro