Re: Review Request 21922: Handover more details on exception in hiveserver2

2014-06-25 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21922/ --- (Updated June 26, 2014, 5:49 a.m.) Review request for hive. Changes ---

Re: Review Request 21922: Handover more details on exception in hiveserver2

2014-05-28 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21922/#review44221 --- Ship it! Thanks , its better to be clearer in my opinion, but its p

Re: Review Request 21922: Handover more details on exception in hiveserver2

2014-05-28 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21922/ --- (Updated May 29, 2014, 12:41 a.m.) Review request for hive. Changes ---

Re: Review Request 21922: Handover more details on exception in hiveserver2

2014-05-28 Thread Navis Ryu
> On May 28, 2014, 6:58 p.m., Szehon Ho wrote: > > service/src/java/org/apache/hive/service/cli/HiveSQLException.java, line 157 > > > > > > Can we consider abstracting this kind of logic into an inner class, so > > en

Re: Review Request 21922: Handover more details on exception in hiveserver2

2014-05-28 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21922/#review44140 --- I have some comments below. service/src/java/org/apache/hive/servi

Review Request 21922: Handover more details on exception in hiveserver2

2014-05-27 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21922/ --- Review request for hive. Bugs: HIVE-7127 https://issues.apache.org/jira/bro