Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-16 Thread Swarnim Kulkarni
> On May 7, 2014, 11:27 p.m., Xuefu Zhang wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java, > > line 132 > > > > > > Is FamilyFilter appropriate here? That's exactly what I

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-13 Thread Xuefu Zhang
> On May 12, 2014, 4:56 a.m., Swarnim Kulkarni wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java, > > line 132 > > > > > > That said, I am also not a 100% positive on why Nav

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-12 Thread Xuefu Zhang
> On May 12, 2014, 4:53 a.m., Swarnim Kulkarni wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java, > > line 132 > > > > > > Sure. Basically the current implementation in hive

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-12 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21138/ --- (Updated May 8, 2014, 3:42 p.m.) Review request for hive. Changes --- Up

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-11 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21138/#review42666 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseK

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-11 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21138/#review42667 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseK

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-10 Thread Xuefu Zhang
> On May 7, 2014, 11:27 p.m., Xuefu Zhang wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseKeyFactory.java, > > line 132 > > > > > > Is FamilyFilter appropriate here? > > Swarnim Kulkarni

Re: Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-10 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21138/#review42436 --- hbase-handler/src/java/org/apache/hadoop/hive/hbase/CompositeHBaseK

Review Request 21138: Support more generic way of using composite key for HBaseHandler

2014-05-06 Thread Swarnim Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21138/ --- Review request for hive. Repository: hive-git Description --- HIVE-2599