Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-16 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated May 9, 2014, 8:16 p.m.) Review request for hive, Gopal V and Gunther H

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-15 Thread Sergey Shelukhin
> On May 9, 2014, 1:58 a.m., Gunther Hagleitner wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java, line 147 > > > > > > randomaccess doesn't extend output? no - Sergey -

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-15 Thread Gunther Hagleitner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review42539 --- ql/src/java/org/apache/hadoop/hive/ql/debug/Utils.java

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-15 Thread Sergey Shelukhin
> On May 8, 2014, 10:05 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java, line 405 > > > > > > why do you need this? this seems to do the same thing as tag == -1?

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-15 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated May 14, 2014, 8:22 p.m.) Review request for hive, Gopal V and Gunther

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-10 Thread Gunther Hagleitner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review42555 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinPr

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-01 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review41936 --- Ship it! Ship It! - Gopal V On May 1, 2014, 2:29 a.m., Sergey Sh

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-05-01 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review41935 --- Ship it! Ship It! - Gopal V On May 1, 2014, 2:29 a.m., Sergey Sh

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated May 1, 2014, 2:29 a.m.) Review request for hive, Gopal V and Gunther H

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review41892 --- conf/hive-default.xml.template

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 30, 2014, 11:14 p.m.) Review request for hive, Gopal V and Gunth

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-30 Thread Sergey Shelukhin
> On April 30, 2014, 2:37 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java, line 248 > > > > > > {} block please, I almost missed reading that. sorry, that is left over from de

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-29 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review41798 --- Minor comments, mostly related to JIT inlining. Otherwise I'm on bo

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 30, 2014, 2:03 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-25 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 26, 2014, 1:53 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 18, 2014, 1 a.m.) Review request for hive, Gopal V and Gunther H

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-04-16 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated April 17, 2014, 1:07 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-20 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 20, 2014, 11:26 p.m.) Review request for hive, Gopal V and Gunth

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review37681 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-18 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 19, 2014, 2:40 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 17, 2014, 8:24 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 15, 2014, 3:35 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review37309 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 15, 2014, 1:22 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 15, 2014, 1:17 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-13 Thread Sergey Shelukhin
> On March 13, 2014, 6 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java, > > line 31 > > > > > > The ref longs are not just indexes, they contain bits from var

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-12 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review36939 --- ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMu

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-11 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- (Updated March 12, 2014, 2:30 a.m.) Review request for hive, Gopal V and Gunthe

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-11 Thread Sergey Shelukhin
> On March 11, 2014, 12:30 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java, > > line 195 > > > > > > Quadriatic probing is much nicer for collisions. this i

Re: Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-10 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review36680 --- ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMu

Review Request 18936: HIVE-6430 MapJoin hash table has large memory overhead

2014-03-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/ --- Review request for hive, Gopal V and Gunther Hagleitner. Repository: hive-git