Re: Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-02-05 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17622/#review33747 --- Ship it! Ship It! - Eric Hanson On Jan. 31, 2014, 10:19 p.m., Ji

Re: Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-02-05 Thread Jitendra Pandey
> On Feb. 3, 2014, 6:20 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java, > > line 208 > > > > > > Please add a comment why you are using decimal.* and why it's dif

Re: Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-02-03 Thread Eric Hanson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17622/#review33378 --- Looks good to me. See one comment inline. ql/src/java/org/apache/h

Review Request 17622: VectorExpressionWriter for date and decimal datatypes.

2014-01-31 Thread Jitendra Pandey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17622/ --- Review request for hive and Eric Hanson. Repository: hive-git Description ---